Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2093423003: X87: [builtins] Introduce proper Float64Atan and Float64Atan2 operators. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Introduce proper Float64Atan and Float64Atan2 operators. port 89d8c57b9c3b29e7977b13f0a9eed6bd8fb6772d (r36916) original commit message: Import base::ieee754::atan() and base::ieee754::atan2() from fdlibm and introduce Float64Atan and Float64Atan2 TurboFan operators based on those, similar to what we already did for Float64Log and Float64Log1p. Rewrite Math.atan() and Math.atan2() as TurboFan builtin and use the operators to also inline Math.atan() and Math.atan2() into optimized TurboFan functions. BUG= Committed: https://crrev.com/4953b17c52df8ba6c9e07058e5dd0e3123f31481 Cr-Commit-Position: refs/heads/master@{#37262}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 2 chunks +30 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-06-27 02:08:03 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-06-27 02:10:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093423003/1
4 years, 5 months ago (2016-06-27 02:12:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 02:37:02 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 02:37:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4953b17c52df8ba6c9e07058e5dd0e3123f31481
Cr-Commit-Position: refs/heads/master@{#37262}

Powered by Google App Engine
This is Rietveld 408576698