Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1655)

Issue 2093423002: Move web-animations-api tests not being upstreamed (Closed)

Created:
4 years, 5 months ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move web-animations-api tests not being upstreamed In preparation for upstreaming the tests in LayoutTests/web-animations-api to the W3C web-platform-tests test suite, this patch moves tests that will not be upstreamed to LayoutTests/animations. One obsolete test (timeline-play-animation.html) is also deleted (document.timeline.play is no longer in the spec). BUG=623437 Committed: https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52 Cr-Commit-Position: refs/heads/master@{#403103}

Patch Set 1 #

Patch Set 2 : Move two additional tests #

Total comments: 1

Patch Set 3 : Undo move of reject-hyphen.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-40 lines, -1304 lines) Patch
A + third_party/WebKit/LayoutTests/animations/animations-responsive-assorted-lengths.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-backgroundPosition.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-backgroundSize.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-borderImageWidth.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-borderRadius.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-borderWidth.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-boxShadow.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-fontSize.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-fontWeight.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-minHeight.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-motionOffset.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-opacity.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-perspective.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-shapeMargin.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-strokeDasharray.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-textIndent.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-to-color-change.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-to-inherited-change.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-to-style-change.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-transform.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-translate.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-verticalAlign.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/change-in-animation-frame.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/change-in-animation-frame-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/deprecated-hyphen.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/deprecated-hyphen-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/element-animate-float-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/element-animate-float-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/element-animate-font-style-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/element-animate-font-style-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/element-animate-no-style-recalc.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/element-animate-position-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/element-animate-position-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/finish-event-after-gc.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/font-builder-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/font-builder-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/get-css-players.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/option-element-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/option-element-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/resource-loading.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/resource-loading-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/start-time-grouping.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/transitions-replay.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-assorted-lengths.html View 1 chunk +0 lines, -102 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-backgroundPosition.html View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-backgroundSize.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-borderImageWidth.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-borderRadius.html View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-borderWidth.html View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-boxShadow.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-fontSize.html View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-fontWeight.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-minHeight.html View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-motionOffset.html View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-opacity.html View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-perspective.html View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-shapeMargin.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-strokeDasharray.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-textIndent.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-to-color-change.html View 1 chunk +0 lines, -237 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-to-inherited-change.html View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-to-style-change.html View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-transform.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-translate.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animations-responsive-verticalAlign.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/change-in-animation-frame.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/change-in-animation-frame-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/deprecated-hyphen.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/deprecated-hyphen-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/element-animate-float-crash.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/element-animate-float-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/element-animate-font-style-crash.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/element-animate-font-style-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/element-animate-no-style-recalc.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/element-animate-position-crash.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/element-animate-position-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/finish-event-after-gc.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/font-builder-crash.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/font-builder-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/option-element-crash.html View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/option-element-crash-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/resource-loading.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/resource-loading-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/start-time-grouping.html View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/timeline-play-animation.html View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/transitions-replay.html View 1 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/w3c/get-css-players.html View 1 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
suzyh_UTC10 (ex-contributor)
4 years, 5 months ago (2016-06-27 01:56:03 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093423002/1
4 years, 5 months ago (2016-06-27 01:59:12 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-27 03:07:25 UTC) #7
alancutter (OOO until 2018)
https://codereview.chromium.org/2093423002/diff/20001/third_party/WebKit/LayoutTests/animations/reject-hyphen.html File third_party/WebKit/LayoutTests/animations/reject-hyphen.html (right): https://codereview.chromium.org/2093423002/diff/20001/third_party/WebKit/LayoutTests/animations/reject-hyphen.html#newcode20 third_party/WebKit/LayoutTests/animations/reject-hyphen.html:20: }, 'Hyphenated propery names are ignored.'); This should be ...
4 years, 5 months ago (2016-06-29 05:47:25 UTC) #8
suzyh_UTC10 (ex-contributor)
On 2016/06/29 at 05:47:25, alancutter wrote: > https://codereview.chromium.org/2093423002/diff/20001/third_party/WebKit/LayoutTests/animations/reject-hyphen.html > File third_party/WebKit/LayoutTests/animations/reject-hyphen.html (right): > > https://codereview.chromium.org/2093423002/diff/20001/third_party/WebKit/LayoutTests/animations/reject-hyphen.html#newcode20 ...
4 years, 5 months ago (2016-06-29 23:51:04 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093423002/40001
4 years, 5 months ago (2016-06-29 23:52:33 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 01:19:22 UTC) #13
alancutter (OOO until 2018)
lgtm
4 years, 5 months ago (2016-06-30 04:30:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093423002/40001
4 years, 5 months ago (2016-06-30 06:36:04 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-30 06:41:55 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 06:42:02 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 06:46:13 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52
Cr-Commit-Position: refs/heads/master@{#403103}

Powered by Google App Engine
This is Rietveld 408576698