Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2093413002: Re-enable two flaky tests that were disabled due to timeouts. (Closed)

Created:
4 years, 5 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org, Patrick Monette
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable two flaky tests that were disabled due to timeouts. ImageDecoderBrowserTest.StartAndKillProcess and UtilityProcessMojoClientBrowserTest.ConnectionError were disabled due to an internal Mojo bug in channel disconnections. The bug was fixed in http://crrev.com/401698 and http://crrev.com/401869. BUG=618206 Committed: https://crrev.com/488d7009a11df5d1553e1f716ef95bd75784acab Cr-Commit-Position: refs/heads/master@{#403567}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M chrome/browser/image_decoder_browsertest.cc View 1 chunk +1 line, -10 lines 0 comments Download
M content/browser/utility_process_mojo_client_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Anand Mistry (off Chromium)
4 years, 5 months ago (2016-06-27 00:57:26 UTC) #2
Anand Mistry (off Chromium)
Ping!
4 years, 5 months ago (2016-06-30 05:47:22 UTC) #3
brettw
Sorry for the delay! LGTM
4 years, 5 months ago (2016-07-01 17:48:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093413002/1
4 years, 5 months ago (2016-07-01 23:01:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 23:59:20 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 23:59:22 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-02 00:00:27 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/488d7009a11df5d1553e1f716ef95bd75784acab
Cr-Commit-Position: refs/heads/master@{#403567}

Powered by Google App Engine
This is Rietveld 408576698