Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: remoting/resources/BUILD.gn

Issue 2093393002: Work in progress to port remoting_me2me_host_archive (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make localized prefpane infoplist strings work Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/remoting_version.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/resources/BUILD.gn
diff --git a/remoting/resources/BUILD.gn b/remoting/resources/BUILD.gn
index ddc1b0bb25eb8e5797b09e3f06b0f23d1957a45d..3cc91d80167efed6b49f48d19ada60805208a4a1 100644
--- a/remoting/resources/BUILD.gn
+++ b/remoting/resources/BUILD.gn
@@ -13,60 +13,56 @@ group("resources") {
public_deps = [
":copy_locales",
":strings",
-
- #":verify_resources", TODO(GYP) enable this.
+ ":verify_resources",
]
}
# TODO(GYP) enable verify_resources. The bots are complaining about
# gen/main.html not being found but this doesn't seems to reproduce locally.
-if (false) {
- action("verify_resources") {
- script = "//remoting/tools/verify_resources.py"
-
- sources_to_verify = [
- "$root_gen_dir/main.html",
- "../base/resources_unittest.cc",
- "../host/continue_window_mac.mm",
- "../host/disconnect_window_mac.mm",
- "../host/installer/mac/uninstaller/remoting_uninstaller-InfoPlist.strings.jinja2",
- "../host/mac/me2me_preference_pane-InfoPlist.strings.jinja2",
- "../host/win/core.rc.jinja2",
- "../host/win/host_messages.mc.jinja2",
- "../host/win/version.rc.jinja2",
- "../resources/play_store_resources.cc",
- "../webapp/background/background.js",
- "../webapp/butter_bar.js",
- "../webapp/client_screen.js",
- "../webapp/error.js",
- "../webapp/host_list.js",
- "../webapp/host_setup_dialog.js",
- "../webapp/host_table_entry.js",
- "../webapp/manifest.json.jinja2",
- "../webapp/paired_client_manager.js",
- "../webapp/remoting.js",
- "../webapp/window_frame.js",
- ]
- inputs = [ "remoting_strings.grd" ] + sources_to_verify
+action("verify_resources") {
+ script = "//remoting/tools/verify_resources.py"
+
+ sources_to_verify = [
+ # "$root_gen_dir/main.html",
+ "../host/continue_window_mac.mm",
+ "../host/disconnect_window_mac.mm",
+ "../host/installer/mac/uninstaller/remoting_uninstaller-InfoPlist.strings.jinja2",
+ "../host/mac/me2me_preference_pane-InfoPlist.strings.jinja2",
+ "../host/win/core.rc.jinja2",
+ "../host/win/host_messages.mc.jinja2",
+ "../host/win/version.rc.jinja2",
+ "../resources/play_store_resources.cc",
+ "../webapp/crd/js/background.js",
+ "../webapp/crd/js/butter_bar.js",
+ "../webapp/base/js/error.js",
+ "../webapp/crd/js/host_list.js",
+ "../webapp/crd/js/host_setup_dialog.js",
+ "../webapp/crd/js/host_table_entry.js",
+ "../webapp/crd/manifest.json.jinja2",
+ "../webapp/crd/js/paired_client_manager.js",
+ "../webapp/crd/js/desktop_remoting.js",
+ "../webapp/crd/js/window_frame.js",
+ ]
+
+ inputs = [ "remoting_strings.grd" ] + sources_to_verify
- stampfile = "$root_build_dir/remoting_resources_verified_stamp"
- outputs = [
- stampfile,
- ]
+ stampfile = "$root_build_dir/remoting_resources_verified_stamp"
+ outputs = [
+ stampfile,
+ ]
- args = [
- "-t",
- rebase_path(stampfile, root_build_dir),
- "-r",
- rebase_path("remoting_strings.grd", root_build_dir),
- ] + rebase_path(sources_to_verify, root_build_dir)
+ args = [
+ "-t",
+ rebase_path(stampfile, root_build_dir),
+ "-r",
+ rebase_path("remoting_strings.grd", root_build_dir),
+ ] + rebase_path(sources_to_verify, root_build_dir)
- deps = [
- "//remoting/webapp:main_html",
- ] # Generates main.html.
- }
-} # if false
+ deps = [
+ # "//remoting/webapp:webapp",
+ ] # Generates main.html.
+}
if (is_android) {
android_string_outputs =
« no previous file with comments | « remoting/remoting_version.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698