Implement disabledAttributeChanged() in HTMLInputElement.

Implement disabledAttributeChanged() in HTMLInputElement.

when called disabledAttributeChanged() at of HTMLFieldSetElement,
call the m_inputTypeView->disabledAttributeChanged() for update at HTMLInputElement.

BUG=621870
Committed: https://crrev.com/3849599529aec6e8f8048086ddb6fd9ef8a9e554
Cr-Commit-Position: refs/heads/master@{#402562}

[Hwanseung Lee(hs1217.lee), 2016-06-26 08:48:11]

Description was changed from

==========
Implement disabledAttributeChanged() in HTMLInputElement.

when called disabledAttributeChanged() at of HTMLFieldSetElement,
call the m_inputTypeView->disabledAttributeChanged() for update at
HTMLInputElement.

BUG=621870
==========

to

==========
Implement disabledAttributeChanged() in HTMLInputElement.

when called disabledAttributeChanged() at of HTMLFieldSetElement,
call the m_inputTypeView->disabledAttributeChanged() for update at
HTMLInputElement.

BUG=621870
==========

[Hwanseung Lee(hs1217.lee), 2016-06-26 08:48:11]

hs1217.lee@gmail.com changed reviewers:
+ rnimmagadda@chromium.org, tkent@chromium.org

[Hwanseung Lee(hs1217.lee), 2016-06-26 08:52:21]

On 2016/06/26 08:48:11, hs1217.lee wrote:
> mailto:hs1217.lee@gmail.com changed reviewers:
> + mailto:rnimmagadda@chromium.org, mailto:tkent@chromium.org

could you review this commit?
it is related Issue 621870.

i was test first time to call layoutObject()->updateFromElement() in
FileInputType::disabledAttributeChanged() following guide of tkent.
but it is not working.

i found disabledAttributeChanged() is not implement at HTMLInputElement.
so i add disabledAttributeChanged().

thank you.

[tkent, 2016-06-26 23:36:49]

tkent@chromium.org changed reviewers:
- rnimmagadda@chromium.org

[tkent, 2016-06-27 03:17:30]

Thank you for working on this issue.

This change needs a test.  I think a reference test is suitable.

A test file should be in third_party/WebKit/LayoutTests/fast/forms/fieldset/. 
The test should compare rendering results of the scenario in crbug.com/621870
and no disabled attributes from the beginning.

https://codereview.chromium.org/2093383002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLInputElement.cpp (right):

https://codereview.chromium.org/2093383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLInputElement.cpp:1538:
HTMLFormControlElement::disabledAttributeChanged();
Please specify nearest parent class,
HTMLTextFormControlElement::disabledAttributeChanged().

https://codereview.chromium.org/2093383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLInputElement.cpp:1541: 
I think we can remove the block for disabledAttr in
HTMLInputElement::parseAttribute.

[Hwanseung Lee(hs1217.lee), 2016-06-28 02:26:43]

On 2016/06/27 03:17:30, tkent wrote:
> Thank you for working on this issue.
> 
> This change needs a test.  I think a reference test is suitable.
> 
> A test file should be in third_party/WebKit/LayoutTests/fast/forms/fieldset/. 
> The test should compare rendering results of the scenario in crbug.com/621870
> and no disabled attributes from the beginning.
> 
>
https://codereview.chromium.org/2093383002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/html/HTMLInputElement.cpp (right):
> 
>
https://codereview.chromium.org/2093383002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/html/HTMLInputElement.cpp:1538:
> HTMLFormControlElement::disabledAttributeChanged();
> Please specify nearest parent class,
> HTMLTextFormControlElement::disabledAttributeChanged().
> 
>
https://codereview.chromium.org/2093383002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/html/HTMLInputElement.cpp:1541: 
> I think we can remove the block for disabledAttr in
> HTMLInputElement::parseAttribute.

i wonder to make test by testharness.js.
how to access button attribute of "input[type=file]" by javascript?
if can't to access, just i will make test to compare image simply.
i think It is not good. do you have any good idea?

[tkent, 2016-06-28 02:32:43]

On 2016/06/28 at 02:26:43, hs1217.lee wrote:
> i wonder to make test by testharness.js.
> how to access button attribute of "input[type=file]" by javascript?
> if can't to access, just i will make test to compare image simply.
> i think It is not good. do you have any good idea?

It's impossible to test this by testharness.js.  As I already wrote, we should
make a "reference test".
You can find examples of reference tests in
third_party/WebKit/LayoutTests/fast/forms/fieldset/; There are pairs of foo.html
and foo-expected.html.

[Hwanseung Lee(hs1217.lee), 2016-06-28 12:19:07]

sorry. i didn't know about reference test.
so i was searching about that.

i added reference test.
could you review again?

[tkent, 2016-06-28 13:47:35]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-28 13:47:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 14:30:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 14:30:14]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Hwanseung Lee(hs1217.lee), 2016-06-28 14:43:53]

The CQ bit was checked by hs1217.lee@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-28 14:44:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 14:44:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 14:44:13]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[tkent, 2016-06-28 21:13:29]

lgtm.  Thank you for working on this!

[tkent, 2016-06-28 21:13:33]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-06-28 21:14:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 22:09:08]

Description was changed from

==========
Implement disabledAttributeChanged() in HTMLInputElement.

when called disabledAttributeChanged() at of HTMLFieldSetElement,
call the m_inputTypeView->disabledAttributeChanged() for update at
HTMLInputElement.

BUG=621870
==========

to

==========
Implement disabledAttributeChanged() in HTMLInputElement.

when called disabledAttributeChanged() at of HTMLFieldSetElement,
call the m_inputTypeView->disabledAttributeChanged() for update at
HTMLInputElement.

BUG=621870
==========

[commit-bot: I haz the power, 2016-06-28 22:09:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-28 22:10:25]

Description was changed from

==========
Implement disabledAttributeChanged() in HTMLInputElement.

when called disabledAttributeChanged() at of HTMLFieldSetElement,
call the m_inputTypeView->disabledAttributeChanged() for update at
HTMLInputElement.

BUG=621870
==========

to

==========
Implement disabledAttributeChanged() in HTMLInputElement.

when called disabledAttributeChanged() at of HTMLFieldSetElement,
call the m_inputTypeView->disabledAttributeChanged() for update at
HTMLInputElement.

BUG=621870

Committed: https://crrev.com/3849599529aec6e8f8048086ddb6fd9ef8a9e554
Cr-Commit-Position: refs/heads/master@{#402562}
==========

[commit-bot: I haz the power, 2016-06-28 22:10:26]

Patchset 2 (id:??) landed as
https://crrev.com/3849599529aec6e8f8048086ddb6fd9ef8a9e554
Cr-Commit-Position: refs/heads/master@{#402562}