Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2093343002: Scale the emulated event in EventSender when use-zoom-for-dsf is enabled (Closed)

Created:
4 years, 5 months ago by oshima
Modified:
4 years, 5 months ago
CC:
blink-reviews, chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Scale the emulated event in EventSender when use-zoom-for-dsf is enabled * Revert the manual scaling in layout test. BUG=621979 Committed: https://crrev.com/76b6eeb4361c7f4a7dee7fce21f77d0174520e5e Cr-Commit-Position: refs/heads/master@{#402191}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Scale the emulated event in EventSender when use-zoom-for-dsf is enabled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -33 lines) Patch
M components/test_runner/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/event_sender.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/test_runner/event_sender.cc View 1 7 chunks +66 lines, -26 lines 0 comments Download
M components/test_runner/test_runner.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/web_test_delegate.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/test/layouttest_support.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/layouttest_support.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/static/gesture-scroll-amount.html View 3 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/static/mousewheel-scroll-amount.html View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093343002/1
4 years, 5 months ago (2016-06-25 20:51:39 UTC) #2
oshima
tkent@ -> components/test_runner jochen@ -> content/
4 years, 5 months ago (2016-06-25 21:32:31 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/234506)
4 years, 5 months ago (2016-06-25 21:57:52 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093343002/1
4 years, 5 months ago (2016-06-25 22:31:54 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-25 23:32:14 UTC) #12
tkent
test_runner lgtm https://codereview.chromium.org/2093343002/diff/1/components/test_runner/event_sender.h File components/test_runner/event_sender.h (right): https://codereview.chromium.org/2093343002/diff/1/components/test_runner/event_sender.h#newcode208 components/test_runner/event_sender.h:208: std::unique_ptr<blink::WebInputEvent> ScaleEvent( We should have a comment ...
4 years, 5 months ago (2016-06-27 00:54:55 UTC) #13
oshima
https://codereview.chromium.org/2093343002/diff/1/components/test_runner/event_sender.h File components/test_runner/event_sender.h (right): https://codereview.chromium.org/2093343002/diff/1/components/test_runner/event_sender.h#newcode208 components/test_runner/event_sender.h:208: std::unique_ptr<blink::WebInputEvent> ScaleEvent( On 2016/06/27 00:54:55, tkent wrote: > We ...
4 years, 5 months ago (2016-06-27 02:29:36 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093343002/20001
4 years, 5 months ago (2016-06-27 02:29:53 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-27 04:00:53 UTC) #18
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-06-27 07:42:25 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093343002/20001
4 years, 5 months ago (2016-06-27 15:49:52 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-27 15:55:29 UTC) #24
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 15:58:10 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/76b6eeb4361c7f4a7dee7fce21f77d0174520e5e
Cr-Commit-Position: refs/heads/master@{#402191}

Powered by Google App Engine
This is Rietveld 408576698