Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: runtime/bin/crypto_macos.cc

Issue 209333014: Speed up GetRandomBytes by only entering signal-blocking scope once. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add validation and apply in other scenario. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/crypto_linux.cc ('k') | runtime/bin/eventhandler_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/crypto_macos.cc
diff --git a/runtime/bin/crypto_macos.cc b/runtime/bin/crypto_macos.cc
index d808d416b608a571c807fa9fcfc6f97ae6396d37..3498636bb0d27af1a729b229f40f06aab9339900 100644
--- a/runtime/bin/crypto_macos.cc
+++ b/runtime/bin/crypto_macos.cc
@@ -10,7 +10,6 @@
#include "bin/fdutils.h"
#include "bin/crypto.h"
-
#include "platform/signal_blocker.h"
@@ -18,11 +17,24 @@ namespace dart {
namespace bin {
bool Crypto::GetRandomBytes(intptr_t count, uint8_t* buffer) {
- intptr_t fd = TEMP_FAILURE_RETRY(open("/dev/urandom", O_RDONLY));
+ ThreadSignalBlocker signal_blocker(SIGPROF);
+ intptr_t fd = TEMP_FAILURE_RETRY_NO_SIGNAL_BLOCKER(
+ open("/dev/urandom", O_RDONLY));
if (fd < 0) return false;
- intptr_t bytes_read = FDUtils::ReadFromBlocking(fd, buffer, count);
- VOID_TEMP_FAILURE_RETRY(close(fd));
- return bytes_read == count;
+ intptr_t bytes_read = 0;
+ do {
+ int res = TEMP_FAILURE_RETRY_NO_SIGNAL_BLOCKER(
+ read(fd, buffer + bytes_read, count - bytes_read));
+ if (res < 0) {
+ int err = errno;
+ VOID_TEMP_FAILURE_RETRY_NO_SIGNAL_BLOCKER(close(fd));
+ errno = err;
+ return false;
+ }
+ bytes_read += res;
+ } while (bytes_read < count);
+ VOID_TEMP_FAILURE_RETRY_NO_SIGNAL_BLOCKER(close(fd));
+ return true;
}
} // namespace bin
« no previous file with comments | « runtime/bin/crypto_linux.cc ('k') | runtime/bin/eventhandler_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698