Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: runtime/bin/crypto_linux.cc

Issue 209333014: Speed up GetRandomBytes by only entering signal-blocking scope once. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add validation and apply in other scenario. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/bin/crypto_android.cc ('k') | runtime/bin/crypto_macos.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/globals.h" 5 #include "platform/globals.h"
6 #if defined(TARGET_OS_LINUX) 6 #if defined(TARGET_OS_LINUX)
7 7
8 #include <errno.h> // NOLINT 8 #include <errno.h> // NOLINT
9 #include <fcntl.h> // NOLINT 9 #include <fcntl.h> // NOLINT
10 10
11 #include "bin/fdutils.h" 11 #include "bin/fdutils.h"
12 #include "bin/crypto.h" 12 #include "bin/crypto.h"
13 #include "platform/signal_blocker.h" 13 #include "platform/signal_blocker.h"
14 14
15 15
16 namespace dart { 16 namespace dart {
17 namespace bin { 17 namespace bin {
18 18
19 bool Crypto::GetRandomBytes(intptr_t count, uint8_t* buffer) { 19 bool Crypto::GetRandomBytes(intptr_t count, uint8_t* buffer) {
20 intptr_t fd = TEMP_FAILURE_RETRY(open("/dev/urandom", O_RDONLY)); 20 ThreadSignalBlocker signal_blocker(SIGPROF);
21 intptr_t fd = TEMP_FAILURE_RETRY_NO_SIGNAL_BLOCKER(
22 open("/dev/urandom", O_RDONLY));
21 if (fd < 0) return false; 23 if (fd < 0) return false;
22 intptr_t bytes_read = FDUtils::ReadFromBlocking(fd, buffer, count); 24 intptr_t bytes_read = 0;
23 VOID_TEMP_FAILURE_RETRY(close(fd)); 25 do {
24 return bytes_read == count; 26 int res = TEMP_FAILURE_RETRY_NO_SIGNAL_BLOCKER(
27 read(fd, buffer + bytes_read, count - bytes_read));
28 if (res < 0) {
29 int err = errno;
30 VOID_TEMP_FAILURE_RETRY_NO_SIGNAL_BLOCKER(close(fd));
31 errno = err;
32 return false;
33 }
34 bytes_read += res;
35 } while (bytes_read < count);
36 VOID_TEMP_FAILURE_RETRY_NO_SIGNAL_BLOCKER(close(fd));
37 return true;
25 } 38 }
26 39
27 } // namespace bin 40 } // namespace bin
28 } // namespace dart 41 } // namespace dart
29 42
30 #endif // defined(TARGET_OS_LINUX) 43 #endif // defined(TARGET_OS_LINUX)
OLDNEW
« no previous file with comments | « runtime/bin/crypto_android.cc ('k') | runtime/bin/crypto_macos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698