Speed up GetRandomBytes by only entering signal-blocking scope once.

runtime/platform/signal_blocker.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef PLATFORM_SIGNAL_BLOCKER_H_
 #define PLATFORM_SIGNAL_BLOCKER_H_
 
 #include "platform/globals.h"
 
 #if defined(TARGET_OS_WINDOWS)
@@ skipping 61 matching lines @@
 // This macro can be used to insert checks that a call is made, that
 // was expected to not return EINTR, but did it anyway.
 #define NO_RETRY_EXPECTED(expression)                                          \
     ({ intptr_t __result = (expression);                                       \
        ASSERT(__result != -1L || errno != EINTR);                              \
        __result; })
 
 #define VOID_NO_RETRY_EXPECTED(expression)                                     \
     (static_cast<void>(NO_RETRY_EXPECTED(expression)))
 
+// Versions of the above, that does not enter a signal blocking scope. Use only
+// when a signal blocking scope is entered manually.
+#define TEMP_FAILURE_RETRY_NO_SIGNAL_BLOCKER(expression)                       \

[Søren Gjesse, 2014/03/25 08:21:23]

It would be great if this macro could check that a ThreadSignalBlocker is in
scope.

The simple way is to just make it take a ThreadSignalBlocket reference, that it
just asserted to be not NULL in the macro.

ThreadSignalBlocker sb(...)

TEMP_FAILURE_RETRY_NO_SIGNAL_BLOCKER(&sb, ...)

It should brobably be called something like

#define TEMP_FAILURE_RETRY_WITH_SIGNAL_BLOCKER(sb, expresstion)

[Anders Johnsen, 2014/03/25 13:06:03]

I've changed it to validate in debug mode, that it's blocking SIGPROF calls.

+    ({ intptr_t __result;                                                      \
+       do {                                                                    \
+         __result = (expression);                                              \
+       } while ((__result == -1L) && (errno == EINTR));                        \
+       __result; })
+
+#define VOID_TEMP_FAILURE_RETRY_NO_SIGNAL_BLOCKER(expression)                  \
+    (static_cast<void>(TEMP_FAILURE_RETRY_NO_SIGNAL_BLOCKER(expression)))
+
 }  // namespace dart
 
 #endif  // PLATFORM_SIGNAL_BLOCKER_H_