Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Side by Side Diff: runtime/bin/crypto_android.cc

Issue 209333014: Speed up GetRandomBytes by only entering signal-blocking scope once. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/bin/crypto_linux.cc » ('j') | runtime/bin/crypto_macos.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/globals.h" 5 #include "platform/globals.h"
6 #if defined(TARGET_OS_ANDROID) 6 #if defined(TARGET_OS_ANDROID)
7 7
8 #include <errno.h> // NOLINT 8 #include <errno.h> // NOLINT
9 #include <fcntl.h> // NOLINT 9 #include <fcntl.h> // NOLINT
10 10
11 #include "bin/fdutils.h" 11 #include "bin/fdutils.h"
12 #include "bin/crypto.h" 12 #include "bin/crypto.h"
13 13
14 #include "platform/signal_blocker.h" 14 #include "platform/signal_blocker.h"
15 15
16 16
17 namespace dart { 17 namespace dart {
18 namespace bin { 18 namespace bin {
19 19
20 bool Crypto::GetRandomBytes(intptr_t count, uint8_t* buffer) { 20 bool Crypto::GetRandomBytes(intptr_t count, uint8_t* buffer) {
21 intptr_t fd = TEMP_FAILURE_RETRY(open("/dev/urandom", O_RDONLY)); 21 ThreadSignalBlocker signal_blocker(SIGPROF);
22 intptr_t fd = TEMP_FAILURE_RETRY_NO_SIGNAL_BLOCKER(
23 open("/dev/urandom", O_RDONLY));
22 if (fd < 0) return false; 24 if (fd < 0) return false;
23 intptr_t bytes_read = FDUtils::ReadFromBlocking(fd, buffer, count); 25 intptr_t bytes_read = 0;
24 VOID_TEMP_FAILURE_RETRY(close(fd)); 26 do {
25 return bytes_read == count; 27 int res = TEMP_FAILURE_RETRY_NO_SIGNAL_BLOCKER(
28 read(fd, buffer + bytes_read, count - bytes_read));
29 if (res < 0) {
30 int err = errno;
31 VOID_TEMP_FAILURE_RETRY_NO_SIGNAL_BLOCKER(close(fd));
32 errno = err;
33 return false;
34 }
35 bytes_read += res;
36 } while (bytes_read < count);
37 VOID_TEMP_FAILURE_RETRY_NO_SIGNAL_BLOCKER(close(fd));
38 return true;
26 } 39 }
27 40
28 } // namespace bin 41 } // namespace bin
29 } // namespace dart 42 } // namespace dart
30 43
31 #endif // defined(TARGET_OS_ANDROID) 44 #endif // defined(TARGET_OS_ANDROID)
OLDNEW
« no previous file with comments | « no previous file | runtime/bin/crypto_linux.cc » ('j') | runtime/bin/crypto_macos.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698