HTML Imports: A speculative fix for fast/dom/custom/imports-custom-element-abort.html

HTML Imports: A speculative fix for fast/dom/custom/imports-custom-element-abort.html

The test occasionally crashes by touching null HTMLImportsController:m_master in a timer function.
This change cancel the timer when m_master is cleared, and add an ASSERT() to make sure that
|m_master| is available when timer is fired.

BUG=355640
TEST=imports-custom-element-abort.html
R=dominicc

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169962

[Hajime Morrita, 2014-03-24 19:04:09]

PTAL?

[dominicc (has gone to gerrit), 2014-03-25 00:57:52]

On 2014/03/24 19:04:09, morrita1 wrote:
> PTAL?

I agree this is a fix, but does it make sense?

Instead you could push back a little bit in time to learn more about what's
going wrong? For example:

- When a recalc is scheduled, assert that m_master is non-null.
- When m_master is cleared, cancel the recalc timer (and assert it is not
scheduled, if that makes sense).
- When the recalc timer fires, assert that m_master is non-null.

I think these should achieve the same effect but the asserts will tell more
about the nature of the problem?

[Hajime Morrita, 2014-03-25 02:47:40]

> I agree this is a fix, but does it make sense?
You're right. the last change was short sighted.
Thanks for pointing it out!

I updated the CL to that it so that it cancels the timer
and provide better invariant for timer callback. PTAL?

[dominicc (has gone to gerrit), 2014-03-25 05:06:07]

LGTM

[Hajime Morrita, 2014-03-25 17:01:55]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-03-25 17:02:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/morrita@chromium.org/209333012/20001

[commit-bot: I haz the power, 2014-03-25 17:11:48]

Change committed as 169962