Source/devtools/front_end/OverridesSupport.js - Issue 209333008: [DevTools] Support device orientation override on device with sensors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/OverridesSupport.js

Issue 209333008: [DevTools] Support device orientation override on device with sensors. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebaselined test Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/device-orientation-success-expected.txt ('k') | Source/devtools/front_end/OverridesView.js » ('j') | Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/OverridesSupport.js

diff --git a/Source/devtools/front_end/OverridesSupport.js b/Source/devtools/front_end/OverridesSupport.js

index 94d39bbf824b0e67102c702feed87c7f04328d9a..0bfb5ea43dd4b5ff475aff601979f4b2f8d68927 100644

--- a/Source/devtools/front_end/OverridesSupport.js

+++ b/Source/devtools/front_end/OverridesSupport.js

@@ -519,8 +519,6 @@ WebInspector.OverridesSupport.prototype = {

PageAgent.clearDeviceOrientationOverride();

return;

}

- if (WebInspector.OverridesSupport.isInspectingDevice())

- return;

var deviceOrientation = WebInspector.OverridesSupport.DeviceOrientation.parseSetting(WebInspector.settings.deviceOrientationOverride.get());

PageAgent.setDeviceOrientationOverride(deviceOrientation.alpha, deviceOrientation.beta, deviceOrientation.gamma);