[DevTools] Support device orientation override on device with sensors.

Source/modules/device_orientation/DeviceOrientationController.h

Index: Source/modules/device_orientation/DeviceOrientationController.h
diff --git a/Source/modules/device_orientation/DeviceOrientationController.h b/Source/modules/device_orientation/DeviceOrientationController.h
index b12bf6f2521dd83bc791877b849921ae18eee67e..39f85b94a9a115ff45690e7ab296ac663bef5191 100644
--- a/Source/modules/device_orientation/DeviceOrientationController.h
+++ b/Source/modules/device_orientation/DeviceOrientationController.h
@@ -45,6 +45,8 @@ public:
     static DeviceOrientationController& from(Document&);
 
     void didChangeDeviceOrientation(WebCore::DeviceOrientationData*);
+    void setOverride(WebCore::DeviceOrientationData*);
+    void clearOverride();
 
     // Inherited from DOMWindowLifecycleObserver
     virtual void didAddEventListener(DOMWindow*, const AtomicString&) OVERRIDE;
@@ -56,9 +58,13 @@ private:
     virtual void registerWithDispatcher() OVERRIDE;
     virtual void unregisterWithDispatcher() OVERRIDE;
 
+    WebCore::DeviceOrientationData* lastData();
     virtual bool hasLastData() OVERRIDE;
     virtual PassRefPtr<Event> getLastEvent() OVERRIDE;
     virtual bool isNullEvent(Event*) OVERRIDE;
+
+    RefPtrWillBeMember<WebCore::DeviceOrientationData> m_lastOrientation;

[timvolodine, 2014/03/25 15:06:33]

I don't really see why m_lastOrientation is needed. How about having only
m_orientationOverride which would store override data or null if there is no
override. setOverride() would fire didChangeDeviceOrientation() once and set
m_orientationOverride. Inside didChangeDeviceOrientation either fire the
override or do nothing if the override is set. Probably the latter is sufficient
as we need to propagate the data only if it is changing.. wdyt?

[dgozman, 2014/03/25 17:50:30]

You are right. I thought we should keep the last data to restore back after
override, but then I saw dispatcher::latestDeviceOrientationData and forgot to
kill this one.

+    RefPtrWillBeMember<WebCore::DeviceOrientationData> m_override;
 };
 
 } // namespace WebCore