[DevTools] Support device orientation override on device with sensors.

Source/modules/device_orientation/DeviceOrientationController.cpp

 /*
  * Copyright 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *  * Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  *  * Redistributions in binary form must reproduce the above copyright
@@ skipping 22 matching lines @@
 #include "core/page/Page.h"
 #include "modules/device_orientation/DeviceOrientationData.h"
 #include "modules/device_orientation/DeviceOrientationDispatcher.h"
 #include "modules/device_orientation/DeviceOrientationEvent.h"
 
 namespace WebCore {
 
 DeviceOrientationController::DeviceOrientationController(Document& document)
     : DeviceSensorEventController(document)
     , DOMWindowLifecycleObserver(document.domWindow())
+    , m_override(nullptr)

[timvolodine, 2014/03/26 13:20:55]

no need for this, it's initialized to 0 anyway by RefPtr

[dgozman, 2014/03/26 13:51:58]

Done.

 {
 }
 
 DeviceOrientationController::~DeviceOrientationController()
 {
     stopUpdating();
 }
 
 void DeviceOrientationController::didChangeDeviceOrientation(DeviceOrientationData* deviceOrientationData)
 {
+    if (m_override)
+        return;
     dispatchDeviceEvent(DeviceOrientationEvent::create(EventTypeNames::deviceorientation, deviceOrientationData));
 }
 
 const char* DeviceOrientationController::supplementName()
 {
     return "DeviceOrientationController";
 }
 
 DeviceOrientationController& DeviceOrientationController::from(Document& document)
 {
     DeviceOrientationController* controller = static_cast<DeviceOrientationController*>(DocumentSupplement::from(document, supplementName()));
     if (!controller) {
         controller = new DeviceOrientationController(document);
         DocumentSupplement::provideTo(document, supplementName(), adoptPtr(controller));
     }
     return *controller;
 }
 
+WebCore::DeviceOrientationData* DeviceOrientationController::lastData()

[timvolodine, 2014/03/26 13:20:55]

no need for WebCore:: prefix
also everywhere in the code below

[dgozman, 2014/03/26 13:51:58]

Done.

+{
+    return m_override ? m_override.get() : DeviceOrientationDispatcher::instance().latestDeviceOrientationData();
+}
+
 bool DeviceOrientationController::hasLastData()
 {
-    return DeviceOrientationDispatcher::instance().latestDeviceOrientationData();
+    return lastData();
 }
 
 PassRefPtr<Event> DeviceOrientationController::getLastEvent()
 {
-    return DeviceOrientationEvent::create(EventTypeNames::deviceorientation,
-        DeviceOrientationDispatcher::instance().latestDeviceOrientationData());
+    return DeviceOrientationEvent::create(EventTypeNames::deviceorientation, lastData());
 }
 
 void DeviceOrientationController::registerWithDispatcher()
 {
     DeviceOrientationDispatcher::instance().addDeviceOrientationController(this);
 }
 
 void DeviceOrientationController::unregisterWithDispatcher()
 {
     DeviceOrientationDispatcher::instance().removeDeviceOrientationController(this);
@@ skipping 21 matching lines @@
         m_hasEventListener = false;
     }
 }
 
 void DeviceOrientationController::didRemoveAllEventListeners(DOMWindow* window)
 {
     stopUpdating();
     m_hasEventListener = false;
 }
 
+void DeviceOrientationController::setOverride(WebCore::DeviceOrientationData* deviceOrientationData)
+{
+    m_override = nullptr;

[aandrey, 2014/03/25 19:59:44]

FYI, maybe we should add:
if (m_override == deviceOrientationData)
    return;

[timvolodine, 2014/03/26 13:20:55]

hmm not sure about this. you would be comparing pointers here anyway. it's
probably fine to just fire an event every time setOverride is called, makes it
also easier for testing..

[timvolodine, 2014/03/26 13:20:55]

a more direct way would be: m_override.clear(), also below

[dgozman, 2014/03/26 13:51:58]

Done.

+    didChangeDeviceOrientation(deviceOrientationData);
+    m_override = deviceOrientationData;
+}
+
+void DeviceOrientationController::clearOverride()
+{
+    m_override = nullptr;

[aandrey, 2014/03/25 19:59:44]

FYI, maybe we should add:
if (!m_override)
    return;

[timvolodine, 2014/03/26 13:20:55]

+1
that way clearOverride would not interfere with normal dispatch if override was
not set.

[dgozman, 2014/03/26 13:51:58]

I agree. Done.

+    WebCore::DeviceOrientationData* orientation = lastData();
+    if (orientation)
+        didChangeDeviceOrientation(orientation);
+}
+
 } // namespace WebCore