[DevTools] Support device orientation override on device with sensors.

Source/modules/device_orientation/DeviceOrientationController.cpp

 /*
  * Copyright 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *  * Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  *  * Redistributions in binary form must reproduce the above copyright
@@ skipping 22 matching lines @@
 #include "core/page/Page.h"
 #include "modules/device_orientation/DeviceOrientationData.h"
 #include "modules/device_orientation/DeviceOrientationDispatcher.h"
 #include "modules/device_orientation/DeviceOrientationEvent.h"
 
 namespace WebCore {
 
 DeviceOrientationController::DeviceOrientationController(Document& document)
     : DeviceSensorEventController(document)
     , DOMWindowLifecycleObserver(document.domWindow())
+    , m_lastOrientation(nullptr)
+    , m_override(nullptr)
 {
 }
 
 DeviceOrientationController::~DeviceOrientationController()
 {
     stopUpdating();
 }
 
 void DeviceOrientationController::didChangeDeviceOrientation(DeviceOrientationData* deviceOrientationData)
 {
+    if (m_override) {
+        m_lastOrientation = deviceOrientationData;
+        return;

[timvolodine, 2014/03/25 15:06:33]

hmm so I guess we don't fire overrides at regular intervals because they are the
same right? why not simply return here
if(m_override)
  return;

[dgozman, 2014/03/25 17:50:30]

Done.

+    }
     dispatchDeviceEvent(DeviceOrientationEvent::create(EventTypeNames::deviceorientation, deviceOrientationData));
 }
 
 const char* DeviceOrientationController::supplementName()
 {
     return "DeviceOrientationController";
 }
 
 DeviceOrientationController& DeviceOrientationController::from(Document& document)
 {
     DeviceOrientationController* controller = static_cast<DeviceOrientationController*>(DocumentSupplement::from(document, supplementName()));
     if (!controller) {
         controller = new DeviceOrientationController(document);
         DocumentSupplement::provideTo(document, supplementName(), adoptPtr(controller));
     }
     return *controller;
 }
 
+WebCore::DeviceOrientationData* DeviceOrientationController::lastData()
+{
+    return m_override ? m_override.get() : DeviceOrientationDispatcher::instance().latestDeviceOrientationData();
+}
+
 bool DeviceOrientationController::hasLastData()
 {
-    return DeviceOrientationDispatcher::instance().latestDeviceOrientationData();
+    return lastData();
 }
 
 PassRefPtr<Event> DeviceOrientationController::getLastEvent()
 {
-    return DeviceOrientationEvent::create(EventTypeNames::deviceorientation,
-        DeviceOrientationDispatcher::instance().latestDeviceOrientationData());
+    return DeviceOrientationEvent::create(EventTypeNames::deviceorientation, lastData());
 }
 
 void DeviceOrientationController::registerWithDispatcher()
 {
     DeviceOrientationDispatcher::instance().addDeviceOrientationController(this);
 }
 
 void DeviceOrientationController::unregisterWithDispatcher()
 {
     DeviceOrientationDispatcher::instance().removeDeviceOrientationController(this);
@@ skipping 21 matching lines @@
         m_hasEventListener = false;
     }
 }
 
 void DeviceOrientationController::didRemoveAllEventListeners(DOMWindow* window)
 {
     stopUpdating();
     m_hasEventListener = false;
 }
 
+void DeviceOrientationController::setOverride(WebCore::DeviceOrientationData* deviceOrientationData)
+{
+    if (!m_override)
+        m_lastOrientation = DeviceOrientationDispatcher::instance().latestDeviceOrientationData();
+    m_override = nullptr;
+    didChangeDeviceOrientation(deviceOrientationData);
+    m_override = deviceOrientationData;
+}
+
+void DeviceOrientationController::clearOverride()
+{
+    m_override = nullptr;
+    if (m_lastOrientation)

[timvolodine, 2014/03/25 15:06:33]

could you use lastData() here instead of m_lastOrientation?

[dgozman, 2014/03/25 17:50:30]

Done.

+        didChangeDeviceOrientation(m_lastOrientation.get());
+    m_lastOrientation = nullptr;
+}
+
 } // namespace WebCore