Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 209333007: Remove optional type="JavaScript" from script tags (Closed)

Created:
6 years, 9 months ago by davve
Modified:
6 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove optional type="JavaScript" from script tags http://www.whatwg.org/specs/web-apps/current-work/#attr-script-type The type attribute gives the language of the script or format of the data. If the attribute is present, its value must be a valid MIME type. The charset parameter must not be specified. The default, which is used if the attribute is absent, is "text/javascript"." Blink is less strict than other browsers. Removing the optional type attribute enables tests to be run in other browsers, notably Firefox. BUG=308992 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169872

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M LayoutTests/svg/custom/absolute-sized-content-with-resources.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/relative-sized-content.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/relative-sized-content-with-resources.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/relative-sized-image.xhtml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
davve
Ran into these tests when comparing behavior with Firefox for 308992.
6 years, 9 months ago (2014-03-24 14:47:10 UTC) #1
Erik Dahlström (inactive)
On 2014/03/24 14:47:10, David Vest wrote: > Ran into these tests when comparing behavior with ...
6 years, 9 months ago (2014-03-24 15:02:17 UTC) #2
pdr.
On 2014/03/24 15:02:17, Erik Dahlström wrote: > On 2014/03/24 14:47:10, David Vest wrote: > > ...
6 years, 9 months ago (2014-03-24 16:35:14 UTC) #3
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-24 16:35:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/209333007/1
6 years, 9 months ago (2014-03-24 16:35:22 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 17:41:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-24 17:41:29 UTC) #7
pdr.
On 2014/03/24 17:41:29, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 9 months ago (2014-03-24 17:49:25 UTC) #8
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-24 17:49:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/209333007/1
6 years, 9 months ago (2014-03-24 17:49:30 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 18:32:25 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-24 18:32:26 UTC) #12
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-24 19:17:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/209333007/1
6 years, 9 months ago (2014-03-24 19:17:47 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 19:18:05 UTC) #15
Message was sent while issue was closed.
Change committed as 169872

Powered by Google App Engine
This is Rietveld 408576698