Issue 209333004: Revert "A64: Now that we have veneers, fix a couple of branches to directly jump to their target."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 209333004: Revert "A64: Now that we have veneers, fix a couple of branches to directly jump to their target." (Closed)

Created:
6 years, 9 months ago by Sven Panne

Modified:
6 years, 9 months ago

Reviewers:
Alexandre, ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "A64: Now that we have veneers, fix a couple of branches to directly jump to their target." This reverts commit r20169, it heavily regresses a Mozilla test: make -j32 arm64.release.check TESTFLAGS=--time TESTJOBS=mozilla/js1_5/Regress/regress-280769-2 Before: --- Total time: 00:01.928 --- 1 (00:01.911) mozilla/js1_5/Regress/regress-280769-2 2 (00:01.910) mozilla/js1_5/Regress/regress-280769-2 3 (00:01.910) mozilla/js1_5/Regress/regress-280769-2 After: --- Total time: 01:36.025 --- 1 (01:36.004) mozilla/js1_5/Regress/regress-280769-2 2 (01:35.403) mozilla/js1_5/Regress/regress-280769-2 3 (01:32.098) mozilla/js1_5/Regress/regress-280769-2 TBR=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20187

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
	M	src/arm64/regexp-macro-assembler-arm64.cc	View		2 chunks	+12 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

Committed patchset #1 manually as r20187 (presubmit successful).

6 years, 9 months ago (2014-03-24 10:41:39 UTC) #1

Message was sent while issue was closed.

lgtm

Alexandre, any idea why this regressed performance?

Expand Messages | Collapse Messages