Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(60)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: ash/system/DEPS
Issue
2093283002
:
mash: Convert all of //ash/system to use WmShelf (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set:
Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
ash/ash.gyp
ash/aura/wm_shelf_aura.h
ash/aura/wm_shelf_aura.cc
ash/common/shelf/wm_shelf.h
ash/common/shelf/wm_shelf.cc
ash/focus_cycler_unittest.cc
ash/mus/bridge/wm_shelf_mus.h
ash/mus/bridge/wm_shelf_mus.cc
ash/shelf/shelf_layout_manager.h
ash/system/DEPS
ash/system/cast/tray_cast.cc
ash/system/chromeos/network/tray_network.cc
ash/system/chromeos/screen_security/screen_tray_item.cc
ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
ash/system/overview/overview_button_tray.cc
ash/system/toast/toast_manager_unittest.cc
ash/system/toast/toast_overlay.cc
ash/system/tray/system_tray_unittest.cc
ash/system/user/tray_user.cc
ash/system/user/tray_user_unittest.cc
ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
ash/system/web_notification/web_notification_tray_unittest.cc
ash/test/ash_test_base.h
ash/test/ash_test_base.cc
View unified diff
|
Download patch
« ash/shelf/shelf_layout_manager.h
('K') |
« ash/shelf/shelf_layout_manager.h
('k') |
ash/system/cast/tray_cast.cc »
('j') |
ash/system/toast/toast_manager_unittest.cc »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 include_rules = [
1 include_rules = [
2
# NOTE: Use WmShelf for all external shelf access. http://crbug.com/615502
2
# NOTE: Use WmShelf
in //ash/common/shelf
for all external shelf access.
3
"-ash/shelf
/shelf_widget.h
",
3
# See
http://crbug.com/615502
4
"-ash/shelf",
4 "-chromeos",
5 "-chromeos",
5 "+components/prefs",
6 "+components/prefs",
6 "+components/signin/core/account_id",
7 "+components/signin/core/account_id",
7 ]
8 ]
OLD
NEW
« ash/shelf/shelf_layout_manager.h
('K') |
« ash/shelf/shelf_layout_manager.h
('k') |
ash/system/cast/tray_cast.cc »
('j') |
ash/system/toast/toast_manager_unittest.cc »
('J')
Issue 2093283002: mash: Convert all of //ash/system to use WmShelf (Closed)
Created 4 years, 6 months ago by James Cook
Modified 4 years, 5 months ago
Reviewers: msw
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 17
This is Rietveld
408576698
Chromium Code Reviews
Issue 2093283002:
mash: Convert all of //ash/system to use WmShelf (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master