include/v8.h - Issue 209323014: Roll ICU 239289:258359 and add support for external ICU data tables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/v8.h

Issue 209323014: Roll ICU 239289:258359 and add support for external ICU data tables (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/v8.h

diff --git a/include/v8.h b/include/v8.h

index 3bcea9aec112691593cd36c4dea1cb31479f1a5b..f467ed4d887a593f9708993d36a514ec20bcaf75 100644

--- a/include/v8.h

+++ b/include/v8.h

@@ -4954,8 +4954,11 @@ class V8_EXPORT V8 {

/**

* Initialize the ICU library bundled with V8. The embedder should only

* invoke this method when using the bundled ICU. Returns true on success.

+ *

+ * If V8 was compiled with the ICU data in an external file, the location

+ * of the data file as to be passed.

danno 2014/03/25 08:47:21 has to be provided

jochen (gone - plz use gerrit) 2014/03/25 12:04:11 Done.

- static bool InitializeICU();

+ static bool InitializeICU(const char* icu_data_file = NULL);

/**

* Sets the v8::Platform to use. This should be invoked before V8 is

« no previous file with comments | « Makefile ('k') | src/api.cc » ('j') | src/icu_util.cc » ('J')