Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 209323004: Enable x64 build for Android (Closed)

Created:
6 years, 9 months ago by Yang Gu
Modified:
6 years, 9 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@master
Visibility:
Public.

Description

Enable x64 build for Android BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20206

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M build/android.gypi View 2 chunks +14 lines, -2 lines 0 comments Download
M src/sampler.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang Gu
This CL is to enable x64 build of v8. Please review!
6 years, 9 months ago (2014-03-24 08:46:42 UTC) #1
ulan
LGTM, note that I changed the CL description to show that this CL is Android ...
6 years, 9 months ago (2014-03-24 11:02:01 UTC) #2
Yang Gu
Yes, the change is for Android. Thanks!
6 years, 9 months ago (2014-03-24 15:20:54 UTC) #3
ulan
6 years, 9 months ago (2014-03-24 15:56:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r20206 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698