Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: remoting/jingle_glue/network_settings_unittest.cc

Issue 209323002: New policies: enable/disable relay; port range (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: policy_templates.json; addressed other CR comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/jingle_glue/network_settings_unittest.cc
diff --git a/remoting/jingle_glue/network_settings_unittest.cc b/remoting/jingle_glue/network_settings_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..686eb5c2dd0c352e19b9c600fd591bf3a4a2573c
--- /dev/null
+++ b/remoting/jingle_glue/network_settings_unittest.cc
@@ -0,0 +1,38 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/jingle_glue/network_settings.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace remoting {
+
+TEST(ParsePortRange, Basic) {
+ int min_port, max_port;
+
+ // Valid range
+ EXPECT_TRUE(ParsePortRange("1-65535", &min_port, &max_port));
+ EXPECT_EQ(1, min_port);
+ EXPECT_EQ(65535, max_port);
+
+ EXPECT_TRUE(ParsePortRange(" 1 - 65535 ", &min_port, &max_port));
+ EXPECT_EQ(1, min_port);
+ EXPECT_EQ(65535, max_port);
+
+ EXPECT_TRUE(ParsePortRange("12400-12400", &min_port, &max_port));
+ EXPECT_EQ(12400, min_port);
+ EXPECT_EQ(12400, max_port);
+
+ // Invalid
+ EXPECT_FALSE(ParsePortRange("", &min_port, &max_port));
+ EXPECT_FALSE(ParsePortRange("-65535", &min_port, &max_port));
+ EXPECT_FALSE(ParsePortRange("1-", &min_port, &max_port));
+ EXPECT_FALSE(ParsePortRange("-", &min_port, &max_port));
+ EXPECT_FALSE(ParsePortRange("-1-65535", &min_port, &max_port));
+ EXPECT_FALSE(ParsePortRange("0-65535", &min_port, &max_port));
+ EXPECT_FALSE(ParsePortRange("1-65536", &min_port, &max_port));
+ EXPECT_FALSE(ParsePortRange("1-4294967295", &min_port, &max_port));
+ EXPECT_FALSE(ParsePortRange("10-1", &min_port, &max_port));
+}
+
+} // namespace remoting

Powered by Google App Engine
This is Rietveld 408576698