New policies: enable/disable relay; port range

remoting/host/policy_hack/policy_watcher.cc

Index: remoting/host/policy_hack/policy_watcher.cc
diff --git a/remoting/host/policy_hack/policy_watcher.cc b/remoting/host/policy_hack/policy_watcher.cc
index fd1a37b07b7926894deefdac15139f915f949ec5..e603cf5032459caaea20f88d40671df5d4aaa0cc 100644
--- a/remoting/host/policy_hack/policy_watcher.cc
+++ b/remoting/host/policy_hack/policy_watcher.cc
@@ -107,6 +107,12 @@ const char PolicyWatcher::kHostAllowClientPairing[] =
 const char PolicyWatcher::kHostAllowGnubbyAuthPolicyName[] =
     "RemoteAccessHostAllowGnubbyAuth";
 
+const char PolicyWatcher::kRelayPolicyName[] =
+    "RemoteAccessHostAllowRelayedConnection";
+
+const char PolicyWatcher::kUdpPortRangePolicyName[] =
+    "RemoteAccessHostUdpPortRange";

[Joao da Silva, 2014/04/28 12:38:29]

FYI, the policy code now lives in a component at //components/policy, so maybe
you can reuse the policy strings from there.

You'd need to depend on the components.gyp:policy target, and then you can
#include "policy/policy_constants.h" to use the policy names. Note that this
file is generated, look at out/Debug/gen/policy/policy/policy_constants.h to see
it.

Also, you could maybe pass the PolicyService from
g_browser_process->policy_service() or from
ProfilePolicyConnector::policy_service() down to the remoting code, and read the
policies directly from there. The PolicyService is also in the component, so you
don't need to depend on //chrome code.

This is just a suggestion, it's fine as is for this CL.

[dcaiafa, 2014/04/29 18:40:30]

That's great! Thanks for letting us know. I opened crbug.com/368321 to
investigate using //components/policy.

+
 const char PolicyWatcher::kHostDebugOverridePoliciesName[] =
     "RemoteAccessHostDebugOverridePolicies";
 
@@ -130,6 +136,8 @@ PolicyWatcher::PolicyWatcher(
                              std::string());
   default_values_->SetBoolean(kHostAllowClientPairing, true);
   default_values_->SetBoolean(kHostAllowGnubbyAuthPolicyName, true);
+  default_values_->SetBoolean(kRelayPolicyName, true);
+  default_values_->SetString(kUdpPortRangePolicyName, "");
 #if !defined(NDEBUG)
   default_values_->SetString(kHostDebugOverridePoliciesName, std::string());
 #endif
@@ -138,6 +146,7 @@ PolicyWatcher::PolicyWatcher(
   // For most policies these match the defaults.
   bad_type_values_.reset(default_values_->DeepCopy());
   bad_type_values_->SetBoolean(kNatPolicyName, false);
+  bad_type_values_->SetBoolean(kRelayPolicyName, false);
 }
 
 PolicyWatcher::~PolicyWatcher() {