Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1207)

Unified Diff: remoting/base/util_unittest.cc

Issue 209323002: New policies: enable/disable relay; port range (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/base/util_unittest.cc
diff --git a/remoting/base/util_unittest.cc b/remoting/base/util_unittest.cc
index 28fd1a77a3ef4a982a1702749ca5bf7f40ab9751..3150665a46bfb9ea7702115dd80af04bedfd8ec4 100644
--- a/remoting/base/util_unittest.cc
+++ b/remoting/base/util_unittest.cc
@@ -285,4 +285,23 @@ TEST(StringIsUtf8Test, Basic) {
EXPECT_FALSE(StringIsUtf8("\xc0\xc0", 2));
}
+TEST(ParsePortRange, Basic) {
+ int min_port, max_port;
+
+ // Valid range
+ EXPECT_TRUE(ParsePortRange("1-65535", &min_port, &max_port));
+ EXPECT_EQ(1, min_port);
+ EXPECT_EQ(65535, max_port);
+
+ EXPECT_TRUE(ParsePortRange("12400-12400", &min_port, &max_port));
+ EXPECT_EQ(12400, min_port);
+ EXPECT_EQ(12400, max_port);
+
+ // Invalid
+ EXPECT_FALSE(ParsePortRange("0-65535", &min_port, &max_port));
+ EXPECT_FALSE(ParsePortRange("1-65536", &min_port, &max_port));
+ EXPECT_FALSE(ParsePortRange("1-4294967295", &min_port, &max_port));
+ EXPECT_FALSE(ParsePortRange("10-1", &min_port, &max_port));
+}
+
} // namespace remoting

Powered by Google App Engine
This is Rietveld 408576698