New policies: enable/disable relay; port range

remoting/jingle_glue/network_settings.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/jingle_glue/network_settings.h"
+
+#include <limits.h>
+#include <stdlib.h>
+
+namespace remoting {
+
+bool ParsePortRange(const std::string& port_range,
+                    int* out_min_port,
+                    int* out_max_port) {
+  size_t separator_index = port_range.find('-');
+  if (separator_index == std::string::npos)
+    return false;
+
+  int min_port = atoi(port_range.substr(0, separator_index).c_str());

[Sergey Ulanov, 2014/03/27 18:31:20]

With atoi() this function will accept strings like "1foo-100bar". Please use
base::StringToUint() from base/strings/string_number_conversions.h . You may
also need base::TrimWhitespaceASCII() to trim whitespaces if necessary

[dcaiafa, 2014/03/27 19:32:24]

Done.

+  int max_port = atoi(port_range.substr(separator_index + 1).c_str());
+
+  if (min_port <= 0 || min_port > max_port || max_port > USHRT_MAX)
+    return false;
+
+  *out_min_port = min_port;
+  *out_max_port = max_port;
+  return true;
+}
+
+}  // namespace remoting