New policies: enable/disable relay; port range

remoting/jingle_glue/network_settings.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_JINGLE_GLUE_NETWORK_SETTINGS_H_
 #define REMOTING_JINGLE_GLUE_NETWORK_SETTINGS_H_
 
 namespace remoting {
 
 struct NetworkSettings {
 
   // When hosts are configured with NAT traversal disabled they will
   // typically also limit their P2P ports to this range, so that
   // sessions may be blocked or un-blocked via firewall rules.
   static const int kDefaultMinPort = 12400;
   static const int kDefaultMaxPort = 12409;
 
   enum NatTraversalMode {
     // Active NAT traversal using STUN and relay servers.
     NAT_TRAVERSAL_ENABLED,
 
+    // Active NAT traversal using STUN, but don't use relay servers.
+    NAT_TRAVERSAL_ENABLED_NO_RELAY,

[Sergey Ulanov, 2014/03/24 23:37:12]

This breaks LibjingleTransportFactory::EnsureFreshJingleInfo() which only
fetches STUN config in the NAT_TRAVERSAL_ENABLED mode. To avoid bugs like this,
it might be better to replace nat_traversal_mode with nat_traversal_flags and
separate flags for STUN, Relay, and outgoing connections.

[dcaiafa, 2014/03/26 15:29:16]

Good catch! Done.

+
     // Don't use STUN or relay servers. Accept incoming P2P connection
     // attempts, but don't initiate any. This ensures that the peer is
     // on the same network. Note that connection will always fail if
     // both ends use this mode.
     NAT_TRAVERSAL_DISABLED,
 
     // Don't use STUN or relay servers but make outgoing connections.
     NAT_TRAVERSAL_OUTGOING,
   };
 
@@ skipping 13 matching lines @@
 
   // |min_port| and |max_port| specify range (inclusive) of ports used by
   // P2P sessions. Any port can be used when both values are set to 0.
   int min_port;
   int max_port;
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_NETWORK_SETTINGS_H_