Allow Cast certificates to have serial numbers greater than 20 bytes, as well as non-minimal INTEGE…

Allow Cast certificates to have serial numbers greater than 20 bytes, as well as non-minimal INTEGER encodings (invalid DER).

Previously such certificates were rejected, however there are some intermediate device certificates with serial numbers 21 bytes long, so make a temporary allowance.

BUG=621645
Review-Url: https://codereview.chromium.org/2079273004
Cr-Commit-Position: refs/heads/master@{#401019}
(cherry picked from commit c15c91eed960673eff22f0bec50cdab4fd950824 -- with many merge conflicts resolved)

R=mattm@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/36b7414ef935eb3a60ff3d934d722e5eedf055ca

[eroman, 2016-06-24 20:24:37]

eroman@chromium.org changed reviewers:
+ mattm@chromium.org

[eroman, 2016-06-24 20:24:37]

Matt: This is the cherry pick to M52 branch.

It didn't apply cleanly because of the ParsedCertificate changes. So it instead
plumbs through the VerifyCertifcateChain API.

I ran the tests to confirm it still works, but a bit messier than the original.

[mattm, 2016-06-24 20:41:11]

lgtm

[eroman, 2016-06-24 20:59:15]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2016-06-24 20:59:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 20:59:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 20:59:37]

CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true
and NOPRESUBMIT=true in order for the CQ to process them

[eroman, 2016-06-24 21:02:47]

Description was changed from

==========
Allow Cast certificates to have serial numbers greater than 20 bytes, as well as
non-minimal INTEGER encodings (invalid DER).

Previously such certificates were rejected, however there are some intermediate
device certificates with serial numbers 21 bytes long, so make a temporary
allowance.

BUG=621645
Review-Url: https://codereview.chromium.org/2079273004
Cr-Commit-Position: refs/heads/master@{#401019}
(cherry picked from commit c15c91eed960673eff22f0bec50cdab4fd950824 -- with many
merge conflicts resolved)
==========

to

==========
Allow Cast certificates to have serial numbers greater than 20 bytes, as well as
non-minimal INTEGER encodings (invalid DER).

Previously such certificates were rejected, however there are some intermediate
device certificates with serial numbers 21 bytes long, so make a temporary
allowance.

BUG=621645
Review-Url: https://codereview.chromium.org/2079273004
Cr-Commit-Position: refs/heads/master@{#401019}
(cherry picked from commit c15c91eed960673eff22f0bec50cdab4fd950824 -- with many
merge conflicts resolved)

R=mattm@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/36b7414ef935eb3a60ff3d934d72...
==========

[eroman, 2016-06-24 21:02:49]

Committed patchset #1 (id:1) manually as
36b7414ef935eb3a60ff3d934d722e5eedf055ca.