Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1941)

Unified Diff: chrome/browser/resources/components.html

Issue 209313002: Modified components ui to address concern of all the time disabled check update button. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review changes. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/components.html
diff --git a/chrome/browser/resources/components.html b/chrome/browser/resources/components.html
index b37425f7ed4f305a60a274c7923387ceca30aa4e..c09de40b8d825bbaa8e65c58b1bb0c7e661bf6ec 100644
--- a/chrome/browser/resources/components.html
+++ b/chrome/browser/resources/components.html
@@ -13,8 +13,8 @@
<div id="body-container" style="visibility:hidden">
<div id="header"><h1 i18n-content="componentsTitle">TITLE</h1></div>
-
- <div id="componentTemplate">
+ <div id="component-placeholder"></div>
+ <div id="component-template" hidden>
<div id="container" class="vbox-container">
<div id="top" class="wbox">
@@ -45,22 +45,44 @@
<table>
<tr class='component-enabled'>
<td>
- <div class="component-text">
- <div>
- <span class="component-name" dir="ltr"
- jscontent="name">NAME</span>
- <span>
- - <span i18n-content="componentVersion">VERSION</span>
- <span dir="ltr" jscontent="version">x.x.x.x</span>
- </span>
- </div>
- <div class="component-actions" guest-visibility="disabled">
- <button class="button-check-update" jsvalues=".id:id"
- i18n-content="checkUpdate">
- CHECK_UPDATE
- </button>
- </div>
- </div>
+ <table>
+ <tr>
+ <td>
+ <div class="component-text">
+ <div>
+ <span class="component-name" dir="ltr"
+ jscontent="name"></span>
James Hawkins 2014/03/27 20:12:03 nit: Closing brace of wrapped line must be on a ne
Shrikant Kelkar 2014/03/27 22:00:13 Done.
+ <span>
+ - <span i18n-content="componentVersion">VERSION</span>
James Hawkins 2014/03/27 20:12:03 Remove placeholder value, VERSION.
Shrikant Kelkar 2014/03/27 22:00:13 Done.
+ <span dir="ltr" jscontent="version">x.x.x.x</span>
James Hawkins 2014/03/27 20:12:03 Remove placeholder value, x.x.x.x.
Shrikant Kelkar 2014/03/27 22:00:13 Done.
+ </span>
+ </div>
+ </div>
+ </td>
+ </tr>
+ <tr>
+ <td>
+ <div class="component-text">
+ <span>Status</span>
+ -
+ <span class="component-name" dir="ltr"
+ jscontent="status" jsvalues=".id: 'status-' + id">
+ <span>
+ </div>
+ </td>
+ </tr>
+ <tr>
+ <td>
+ <div class="component-actions" guest-visibility="disabled">
+ <button class="button-check-update"
+ jsvalues=".id:id"
James Hawkins 2014/03/27 20:12:03 Indentation should be 4 spaces.
Shrikant Kelkar 2014/03/27 22:00:13 Done.
+ i18n-content="checkUpdate">
+ CHECK_UPDATE
+ </button>
+ </div>
+ </td>
+ </tr>
+ </table>
</td>
</tr>
</table>

Powered by Google App Engine
This is Rietveld 408576698