Chromium Code Reviews| Index: chrome/browser/resources/components.html |
| diff --git a/chrome/browser/resources/components.html b/chrome/browser/resources/components.html |
| index b37425f7ed4f305a60a274c7923387ceca30aa4e..c81bd9439953b2c7e069e2e7935d4268a7a3cd21 100644 |
| --- a/chrome/browser/resources/components.html |
| +++ b/chrome/browser/resources/components.html |
| @@ -13,7 +13,7 @@ |
| <div id="body-container" style="visibility:hidden"> |
| <div id="header"><h1 i18n-content="componentsTitle">TITLE</h1></div> |
| - |
| + <div id="componentPlaceholder"></div> |
|
James Hawkins
2014/03/27 18:46:43
IDs should be dash-form.
Shrikant Kelkar
2014/03/27 19:28:07
Done.
|
| <div id="componentTemplate"> |
| <div id="container" class="vbox-container"> |
| @@ -45,22 +45,44 @@ |
| <table> |
| <tr class='component-enabled'> |
| <td> |
| - <div class="component-text"> |
| - <div> |
| - <span class="component-name" dir="ltr" |
| - jscontent="name">NAME</span> |
| - <span> |
| - - <span i18n-content="componentVersion">VERSION</span> |
| - <span dir="ltr" jscontent="version">x.x.x.x</span> |
| - </span> |
| - </div> |
| - <div class="component-actions" guest-visibility="disabled"> |
| - <button class="button-check-update" jsvalues=".id:id" |
| - i18n-content="checkUpdate"> |
| - CHECK_UPDATE |
| - </button> |
| - </div> |
| - </div> |
| + <table> |
| + <tr> |
| + <td> |
| + <div class="component-text"> |
| + <div> |
| + <span class="component-name" dir="ltr" |
| + jscontent="name">NAME</span> |
|
James Hawkins
2014/03/27 18:46:43
nit: Indentation should be 4 spaces in only.
James Hawkins
2014/03/27 18:46:43
nit: Remove stub content, i.e., NAME.
Shrikant Kelkar
2014/03/27 19:28:07
Done.
Shrikant Kelkar
2014/03/27 19:28:07
Done.
|
| + <span> |
| + - <span i18n-content="componentVersion">VERSION</span> |
| + <span dir="ltr" jscontent="version">x.x.x.x</span> |
| + </span> |
| + </div> |
| + </div> |
| + </td> |
| + </tr> |
| + <tr> |
| + <td> |
| + <div class="component-text"> |
| + <span>Status</span> |
| + - |
| + <span class="component-name" dir="ltr" |
| + jscontent="status" jsvalues=".id: 'status-' + id">Okay</span> |
|
James Hawkins
2014/03/27 18:46:43
nit: 80 cols.
Shrikant Kelkar
2014/03/27 19:28:07
Done.
|
| + <span> |
| + </div> |
| + </td> |
| + </tr> |
| + <tr> |
| + <td> |
| + <div class="component-actions" guest-visibility="disabled"> |
| + <button class="button-check-update" |
| + jsvalues=".id:id" |
| + i18n-content="checkUpdate"> |
| + CHECK_UPDATE |
| + </button> |
| + </div> |
| + </td> |
| + </tr> |
| + </table> |
| </td> |
| </tr> |
| </table> |