Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: chrome/browser/component_updater/component_updater_service.h

Issue 209313002: Modified components ui to address concern of all the time disabled check update button. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/component_updater/component_updater_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component_updater/component_updater_service.h
diff --git a/chrome/browser/component_updater/component_updater_service.h b/chrome/browser/component_updater/component_updater_service.h
index 9ea18dc7c93513c40fe1aec8e95dec5019a56820..35d4b3aa856bed09fbaf4f8f87123c983d4f31e7 100644
--- a/chrome/browser/component_updater/component_updater_service.h
+++ b/chrome/browser/component_updater/component_updater_service.h
@@ -78,16 +78,7 @@ struct CrxComponent {
~CrxComponent();
};
-// Convenience structure to use with component listing / enumeration.
-struct CrxComponentInfo {
- // |id| is currently derived from |CrxComponent.pk_hash|, see rest of the
- // class implementation for details.
- std::string id;
- std::string version;
- std::string name;
- CrxComponentInfo();
- ~CrxComponentInfo();
-};
+struct CrxUpdateItem;
// The component update service is in charge of installing or upgrading
// select parts of chrome. Each part is called a component and managed by
@@ -206,7 +197,13 @@ class ComponentUpdateService {
virtual Status RegisterComponent(const CrxComponent& component) = 0;
// Returns a list of registered components.
- virtual void GetComponents(std::vector<CrxComponentInfo>* components) = 0;
+ virtual std::vector<std::string> GetComponentIDs() const = 0;
+
+ // Returns details about registered component.
+ // Note: Object returned here is owned by this class, in simple words
+ // don't try to free this object.
+ virtual CrxUpdateItem* GetComponentDetails(
+ const std::string& component_id) const = 0;
// Returns an interface for on-demand updates. On-demand updates are
// proactively triggered outside the normal component update service schedule.
@@ -249,7 +246,6 @@ class OnDemandUpdater {
// the heap which the component updater will own.
ComponentUpdateService* ComponentUpdateServiceFactory(
ComponentUpdateService::Configurator* config);
-
} // namespace component_updater
#endif // CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/component_updater/component_updater_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698