Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1985)

Unified Diff: chrome/browser/resources/components.js

Issue 209313002: Modified components ui to address concern of all the time disabled check update button. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/components.js
diff --git a/chrome/browser/resources/components.js b/chrome/browser/resources/components.js
index 8753e3192ab210b51c8f2d1ea813a50ca67c33bd..3c46dd92b09b0375960bfa4769a4f640b97af191 100644
--- a/chrome/browser/resources/components.js
+++ b/chrome/browser/resources/components.js
@@ -14,8 +14,11 @@
function renderTemplate(componentsData) {
// This is the javascript code that processes the template:
var input = new JsEvalContext(componentsData);
- var output = $('componentTemplate');
+ var output = $('component-template').cloneNode(true);
James Hawkins 2014/05/21 16:21:37 Why do you need to clone then remove the component
Shrikant Kelkar 2014/05/23 03:49:23 Not removing component-template, just removing 'hi
+ $('component-placeholder').innerHTML = '';
+ $('component-placeholder').appendChild(output);
jstProcess(input, output);
+ output.removeAttribute('hidden');
}
/**
@@ -73,18 +76,29 @@ function returnComponentsData(componentsData) {
}
/**
+ * This event function is called from component ui indicating changed state
+ * of component updater service.
+ * @param {Object} eventArgs Contains event and component id. Component id is
+ * optional.
+ */
+function onComponentEvent(eventArgs) {
+ if (eventArgs['id']) {
+ var id = eventArgs['id'];
+ $('status-' + id).textContent = eventArgs['event'];
+ }
+}
+
+/**
* Handles an 'enable' or 'disable' button getting clicked.
* @param {HTMLElement} node The HTML element representing the component
* being checked for update.
*/
function handleCheckUpdate(node) {
- node.disabled = true;
+ $('status-' + String(node.id)).textContent = 'Checking for update...';
James Hawkins 2014/05/21 16:21:37 String needs to be translated, i.e., loadTimeData.
Shrikant Kelkar 2014/05/23 03:49:23 Done.
+
// Tell the C++ ComponentssDOMHandler to check for update.
chrome.send('checkUpdate', [String(node.id)]);
}
// Get data and have it displayed upon loading.
document.addEventListener('DOMContentLoaded', requestComponentsData);
-
-// Add handlers to static HTML elements.
-$('button-check-update').onclick = handleCheckUpdate;

Powered by Google App Engine
This is Rietveld 408576698