chrome/browser/resources/components.html - Issue 209313002: Modified components ui to address concern of all the time disabled check update button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/components.html

Issue 209313002: Modified components ui to address concern of all the time disabled check update button. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Code review. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/component_updater_service.cc ('k') | chrome/browser/resources/components.js » ('j') | chrome/browser/resources/components.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/components.html

diff --git a/chrome/browser/resources/components.html b/chrome/browser/resources/components.html

index b37425f7ed4f305a60a274c7923387ceca30aa4e..87c4e91e47e0b30156297a61bcbcb1ab959c1c8f 100644

--- a/chrome/browser/resources/components.html

+++ b/chrome/browser/resources/components.html

@@ -13,8 +13,8 @@

<div id="header"><h1 i18n-content="componentsTitle">TITLE</h1></div>

- <div id="componentTemplate">

+ <div id="component-placeholder"></div>

+ <div id="component-template" hidden>

@@ -45,22 +45,44 @@

<table>

<td>

- <div class="component-text">

- <div>

- <span class="component-name" dir="ltr"

- jscontent="name">NAME</span>

- <span>

- - <span i18n-content="componentVersion">VERSION</span>

- <span dir="ltr" jscontent="version">x.x.x.x</span>

- </span>

- </div>

- <div class="component-actions" guest-visibility="disabled">

- <button class="button-check-update" jsvalues=".id:id"

- i18n-content="checkUpdate">

- CHECK_UPDATE

- </button>

- </div>

+ <table>

+ <tr>

+ <td>

+ <div class="component-text">

+ <div>

+ <span class="component-name" dir="ltr"

+ jscontent="name">

+ </span>

+ <span>

+ - <span i18n-content="componentVersion"></span>

+ <span dir="ltr" jscontent="version"></span>

+ </span>

+ </div>

+ </td>

+ </tr>

+ <tr>

+ <td>

+ <div class="component-text">

+ <span>Status </span>

James Hawkins 2014/05/21 16:21:37 Needs to be i18n-content.

Shrikant Kelkar 2014/05/23 03:49:23 Done.

+ -

+ <span dir="ltr"

+ jscontent="status" jsvalues=".id: 'status-' + id">

+ <span>

+ </div>

+ </td>

+ </tr>

+ <tr>

+ <td>

+ <div class="component-actions" guest-visibility="disabled">

+ <button class="button-check-update"

+ jsvalues=".id:id" i18n-content="checkUpdate">

+ CHECK_UPDATE

James Hawkins 2014/05/21 16:21:37 nit: Remove placeholder text.

Shrikant Kelkar 2014/05/23 03:49:23 Done.

+ </button>

+ </div>

+ </td>

+ </tr>

+ </table>

</td>

</tr>

</table>