Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1578)

Unified Diff: chrome/browser/component_updater/component_updater_service.h

Issue 209313002: Modified components ui to address concern of all the time disabled check update button. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/component_updater_service.h
diff --git a/chrome/browser/component_updater/component_updater_service.h b/chrome/browser/component_updater/component_updater_service.h
index 99164c3b16b4ff568626f586b126b4657e28ec56..6b7bd80eaff6c711d0547eaa0fcaf788e34736b2 100644
--- a/chrome/browser/component_updater/component_updater_service.h
+++ b/chrome/browser/component_updater/component_updater_service.h
@@ -78,16 +78,7 @@ struct CrxComponent {
~CrxComponent();
};
-// Convenience structure to use with component listing / enumeration.
-struct CrxComponentInfo {
- // |id| is currently derived from |CrxComponent.pk_hash|, see rest of the
- // class implementation for details.
- std::string id;
- std::string version;
- std::string name;
- CrxComponentInfo();
- ~CrxComponentInfo();
-};
+struct CrxUpdateItem;
// The component update service is in charge of installing or upgrading
// select parts of chrome. Each part is called a component and managed by
@@ -205,9 +196,6 @@ class ComponentUpdateService {
// before calling Start().
virtual Status RegisterComponent(const CrxComponent& component) = 0;
- // Returns a list of registered components.
- virtual void GetComponents(std::vector<CrxComponentInfo>* components) = 0;
-
// Returns a network resource throttle. It means that a component will be
// downloaded and installed before the resource is unthrottled. This is the
// only function callable from the IO thread.
@@ -221,6 +209,13 @@ class ComponentUpdateService {
friend class OnDemandTester;
private:
+ // Returns a list of registered components.
+ virtual std::vector<std::string> GetComponentIDs() const = 0;
+
+ // Returns details about registered component.
Sorin Jianu 2014/05/16 16:36:09 We need to add a comment here saying that the obje
Shrikant Kelkar 2014/05/16 18:58:56 Done.
+ virtual CrxUpdateItem* GetComponentDetails(
+ const std::string& component_id) const = 0;
+
// Ask the component updater to do an update check for a previously
// registered component, immediately. If an update or check is already
// in progress, returns |kInProgress|.
@@ -236,7 +231,6 @@ typedef ComponentUpdateService::Observer ServiceObserver;
// the heap which the component updater will own.
ComponentUpdateService* ComponentUpdateServiceFactory(
ComponentUpdateService::Configurator* config);
-
} // namespace component_updater
#endif // CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_
« no previous file with comments | « no previous file | chrome/browser/component_updater/component_updater_service.cc » ('j') | chrome/browser/ui/webui/components_ui.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698