Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Unified Diff: chrome/browser/component_updater/component_updater_service.h

Issue 209313002: Modified components ui to address concern of all the time disabled check update button. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Modifications to expose CrxUpdateItem to ComponentsUI as per discussion. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/component_updater_service.h
diff --git a/chrome/browser/component_updater/component_updater_service.h b/chrome/browser/component_updater/component_updater_service.h
index 4474c3d7ed7bb4315be07e9b621ccb5a50a064fc..aafdad76bb72078f26616e85c42cd7d192ac63f7 100644
--- a/chrome/browser/component_updater/component_updater_service.h
+++ b/chrome/browser/component_updater/component_updater_service.h
@@ -78,16 +78,7 @@ struct CrxComponent {
~CrxComponent();
};
-// Convenience structure to use with component listing / enumeration.
-struct CrxComponentInfo {
- // |id| is currently derived from |CrxComponent.pk_hash|, see rest of the
- // class implementation for details.
- std::string id;
- std::string version;
- std::string name;
- CrxComponentInfo();
- ~CrxComponentInfo();
-};
+struct CrxUpdateItem;
// The component update service is in charge of installing or upgrading
// select parts of chrome. Each part is called a component and managed by
@@ -211,7 +202,11 @@ class ComponentUpdateService {
virtual Status RegisterComponent(const CrxComponent& component) = 0;
// Returns a list of registered components.
- virtual void GetComponents(std::vector<CrxComponentInfo>* components) = 0;
+ virtual void GetComponentIDs(std::vector<std::string>* component_ids) = 0;
Sorin Jianu 2014/05/03 01:09:06 Of course these two members would have to be decla
Sorin Jianu 2014/05/03 01:09:06 I would do this: virtual std::vector<std::string>
Shrikant Kelkar 2014/05/05 23:05:18 Done.
Shrikant Kelkar 2014/05/05 23:05:18 Done.
+
+ // Returns details about registered component.
+ virtual void GetComponentDetails(const std::string& component_id,
+ CrxUpdateItem** item) = 0;
// Returns a network resource throttle. It means that a component will be
// downloaded and installed before the resource is unthrottled. This is the
@@ -240,7 +235,6 @@ typedef ComponentUpdateService::Observer ServiceObserver;
// the heap which the component updater will own.
ComponentUpdateService* ComponentUpdateServiceFactory(
ComponentUpdateService::Configurator* config);
-
} // namespace component_updater
#endif // CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_

Powered by Google App Engine
This is Rietveld 408576698