Modified components ui to address concern of all the time disabled check update button.

chrome/browser/ui/webui/components_ui.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/components_ui.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 58 matching lines @@
   virtual void RegisterMessages() OVERRIDE;
 
   // Callback for the "requestComponentsData" message.
   void HandleRequestComponentsData(const base::ListValue* args);
 
   // Callback for the "checkUpdate" message.
   void HandleCheckUpdate(const base::ListValue* args);
 
  private:
   void LoadComponents();
+  void ComponentsDOMHandler::HandleRequestComponentStatus(
+      const base::ListValue* args);
 
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(ComponentsDOMHandler);
 };
 
 ComponentsDOMHandler::ComponentsDOMHandler() {
 }
 
 void ComponentsDOMHandler::RegisterMessages() {
   web_ui()->RegisterMessageCallback("requestComponentsData",
       base::Bind(&ComponentsDOMHandler::HandleRequestComponentsData,
                  base::Unretained(this)));
 
   web_ui()->RegisterMessageCallback("checkUpdate",
       base::Bind(&ComponentsDOMHandler::HandleCheckUpdate,
                  base::Unretained(this)));
+
+  web_ui()->RegisterMessageCallback("requestComponentStatus",

[James Hawkins, 2014/03/27 18:46:43]

nit: The start of parameter rows must align on the same column.

[Shrikant Kelkar, 2014/03/27 19:28:07]

Sorry, didn't understand?

+      base::Bind(&ComponentsDOMHandler::HandleRequestComponentStatus,
+                 base::Unretained(this)));
 }
 
 void ComponentsDOMHandler::HandleRequestComponentsData(
     const base::ListValue* args) {
   LoadComponents();
 }
 
 // This function is called when user presses button from html UI.
 // TODO(shrikant): We need to make this button available based on current
 // state e.g. If component state is currently updating then we need to disable
 // button. (https://code.google.com/p/chromium/issues/detail?id=272540)
 void ComponentsDOMHandler::HandleCheckUpdate(const base::ListValue* args) {
   if (args->GetSize() != 1) {
     NOTREACHED();
     return;
   }
 
   std::string component_id;
   if (!args->GetString(0, &component_id)) {
     NOTREACHED();
     return;
   }
 
   ComponentsUI::OnDemandUpdate(component_id);
 }
 
+void ComponentsDOMHandler::HandleRequestComponentStatus(
+    const base::ListValue* args) {
+  if (args->GetSize() != 1) {
+    NOTREACHED();
+    return;
+  }
+
+  std::string component_id;
+  if (!args->GetString(0, &component_id)) {
+    NOTREACHED();
+    return;
+  }
+
+  component_updater::ComponentUpdateService* cus =
+      g_browser_process->component_updater();
+  component_updater::ComponentUpdateService::Status status =
+      cus->GetComponentStatus(component_id);
+
+  std::string string_status;
+  if (status == component_updater::ComponentUpdateService::kInProgress)
+    string_status = "in-progress";
+  else if (status == component_updater::ComponentUpdateService::kOk)
+    string_status = "ok";
+  else
+    string_status = "error";
+
+  web_ui()->CallJavascriptFunction("returnComponentStatus",
+                                   base::StringValue(component_id),
+                                   base::StringValue(string_status));
+}
+
 void ComponentsDOMHandler::LoadComponents() {
   component_updater::ComponentUpdateService* cus =
       g_browser_process->component_updater();
   std::vector<component_updater::CrxComponentInfo> components;
   cus->GetComponents(&components);
 
   // Construct DictionaryValues to return to UI.
   base::ListValue* component_list = new base::ListValue();
   for (size_t j = 0; j < components.size(); ++j) {
     const component_updater::CrxComponentInfo& component = components[j];
 
     base::DictionaryValue* component_entry = new base::DictionaryValue();
     component_entry->SetString("id", component.id);
     component_entry->SetString("name", component.name);
     component_entry->SetString("version", component.version);
+    switch (component.status) {
+      case component_updater::ComponentUpdateService::kInProgress:
+        component_entry->SetString("status", "in-progress");
+        break;
+      case component_updater::ComponentUpdateService::kOk:
+        component_entry->SetString("status", "ok");
+        break;
+      case component_updater::ComponentUpdateService::kError:
+        component_entry->SetString("status", "error");
+        break;
+    }
 
     component_list->Append(component_entry);
   }
 
   base::DictionaryValue results;
   results.Set("components", component_list);
   web_ui()->CallJavascriptFunction("returnComponentsData", results);
 }
 
 }  // namespace
@@ skipping 18 matching lines @@
       g_browser_process->component_updater();
   cus->OnDemandUpdate(component_id);
 }
 
 // static
 base::RefCountedMemory* ComponentsUI::GetFaviconResourceBytes(
       ui::ScaleFactor scale_factor) {
   return ResourceBundle::GetSharedInstance().
       LoadDataResourceBytesForScale(IDR_PLUGINS_FAVICON, scale_factor);
 }