Modified components ui to address concern of all the time disabled check update button.

chrome/browser/resources/components.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * Takes the |componentsData| input argument which represents data about the
  * currently installed components and populates the html jstemplate with
  * that data. It expects an object structure like the above.
  * @param {Object} componentsData Detailed info about installed components.
  *      Same expected format as returnComponentsData().
  */
 function renderTemplate(componentsData) {
   // This is the javascript code that processes the template:
   var input = new JsEvalContext(componentsData);
-  var output = $('componentTemplate');
+  var output = $('componentTemplate').cloneNode(true);

[James Hawkins, 2014/03/27 18:46:43]

Why do you need to clone?

[Shrikant Kelkar, 2014/03/27 19:28:07]

I am rewriting contents of the template in jstProcess()

+  $('componentPlaceholder').innerHTML = '';
+  $('componentPlaceholder').appendChild(output);
   jstProcess(input, output);
+  output.style.visibility = 'visible';
 }
 
 /**
  * Asks the C++ ComponentsDOMHandler to get details about the installed
  * components.
  * The ComponentsDOMHandler should reply to returnComponentsData() (below).
  */
 function requestComponentsData() {
   chrome.send('requestComponentsData');
 }
@@ skipping 36 matching lines @@
   }
 
   // Disable some controls for Guest in ChromeOS.
   if (cr.isChromeOS)
     uiAccountTweaks.UIAccountTweaks.applyGuestModeVisibility(document);
 
   bodyContainer.style.visibility = 'visible';
   body.className = 'show-tmi-mode-initial';
 }
 
+function returnComponentStatus(component_id, status) {

[James Hawkins, 2014/03/27 18:46:43]

Who calls this?

[Shrikant Kelkar, 2014/03/27 19:28:07]

component_ui.cc in response to requestComponentStatus().

+  $('status-' + component_id).innerText = status;

[James Hawkins, 2014/03/27 18:46:43]

Use textContent, not innerText.

[Shrikant Kelkar, 2014/03/27 19:28:07]

Done.

+  var node = $(component_id);
+  if (status == 'in-progress') {
+    node.disabled = true;
+    window.setTimeout(function() { updateComponentStatus(node); }, 1000);

[James Hawkins, 2014/03/27 18:46:43]

nit: Move 1000 to a well-named constant.

[Shrikant Kelkar, 2014/03/27 19:28:07]

Done.

+  } else {
+    node.disabled = false;
+  }
+}
+
+function updateComponentStatus(node) {
+  chrome.send('requestComponentStatus', [String(node.id)]);
+}
+
 /**
  * Handles an 'enable' or 'disable' button getting clicked.
  * @param {HTMLElement} node The HTML element representing the component
  *     being checked for update.
  */
 function handleCheckUpdate(node) {
   node.disabled = true;
+
+  $('status-' + String(node.id)).innerText = 'Checking for update...';

[James Hawkins, 2014/03/27 18:46:43]

textContent

[Shrikant Kelkar, 2014/03/27 19:28:07]

Done.

+
   // Tell the C++ ComponentssDOMHandler to check for update.
   chrome.send('checkUpdate', [String(node.id)]);
+  window.setTimeout(function() { updateComponentStatus(node); }, 1000);
 }
 
 // Get data and have it displayed upon loading.
 document.addEventListener('DOMContentLoaded', requestComponentsData);
-
-// Add handlers to static HTML elements.
-$('button-check-update').onclick = handleCheckUpdate;