Chromium Code Reviews Chromium Code Reviews
Issue 209313002:
Modified components ui to address concern of all the time disabled check update button. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW |
|---|---|
| 1 <!DOCTYPE HTML> | 1 <!DOCTYPE HTML> |
| 2 <html i18n-values="dir:textdirection;"> | 2 <html i18n-values="dir:textdirection;"> |
| 3 <head> | 3 <head> |
| 4 <meta charset="utf-8"> | 4 <meta charset="utf-8"> |
| 5 <title i18n-content="componentsTitle"></title> | 5 <title i18n-content="componentsTitle"></title> |
| 6 <link rel="stylesheet" href="components.css"> | 6 <link rel="stylesheet" href="components.css"> |
| 7 <if expr="chromeos"> | 7 <if expr="chromeos"> |
| 8 <link rel="stylesheet" | 8 <link rel="stylesheet" |
| 9 href="chrome://resources/css/chromeos/ui_account_tweaks.css"> | 9 href="chrome://resources/css/chromeos/ui_account_tweaks.css"> |
| 10 </if> | 10 </if> |
| 11 </head> | 11 </head> |
| 12 <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize"> | 12 <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize"> |
| 13 <div id="body-container" style="visibility:hidden"> | 13 <div id="body-container" style="visibility:hidden"> |
| 14 | 14 |
| 15 <div id="header"><h1 i18n-content="componentsTitle">TITLE</h1></div> | 15 <div id="header"><h1 i18n-content="componentsTitle">TITLE</h1></div> |
| 16 | 16 <div id="componentPlaceholder"></div> |
|
James Hawkins
2014/03/27 18:46:43
IDs should be dash-form.
Shrikant Kelkar
2014/03/27 19:28:07
Done.
| |
| 17 <div id="componentTemplate"> | 17 <div id="componentTemplate"> |
| 18 | 18 |
| 19 <div id="container" class="vbox-container"> | 19 <div id="container" class="vbox-container"> |
| 20 <div id="top" class="wbox"> | 20 <div id="top" class="wbox"> |
| 21 | 21 |
| 22 <div class="section-header"> | 22 <div class="section-header"> |
| 23 <table><tr> | 23 <table><tr> |
| 24 <td> | 24 <td> |
| 25 <span class="section-header-title" i18n-content="componentsTitle" | 25 <span class="section-header-title" i18n-content="componentsTitle" |
| 26 >TITLE</span> | 26 >TITLE</span> |
| (...skipping 11 matching lines...) Expand all Loading... | |
| 38 <div class="component-name no-components" jsdisplay="components.length === 0"> | 38 <div class="component-name no-components" jsdisplay="components.length === 0"> |
| 39 <div i18n-content="noComponents">NO_COMPONENTS_ARE_INSTALLED</div> | 39 <div i18n-content="noComponents">NO_COMPONENTS_ARE_INSTALLED</div> |
| 40 </div> | 40 </div> |
| 41 | 41 |
| 42 <div jsdisplay="components.length > 0"> | 42 <div jsdisplay="components.length > 0"> |
| 43 <div class="component" | 43 <div class="component" |
| 44 jsselect="components"> | 44 jsselect="components"> |
| 45 <table> | 45 <table> |
| 46 <tr class='component-enabled'> | 46 <tr class='component-enabled'> |
| 47 <td> | 47 <td> |
| 48 <div class="component-text"> | 48 <table> |
| 49 <div> | 49 <tr> |
| 50 <span class="component-name" dir="ltr" | 50 <td> |
| 51 jscontent="name">NAME</span> | 51 <div class="component-text"> |
| 52 <span> | 52 <div> |
| 53 - <span i18n-content="componentVersion">VERSION</span> | 53 <span class="component-name" dir="ltr" |
| 54 <span dir="ltr" jscontent="version">x.x.x.x</span> | 54 jscontent="name">NAME</span> |
|
James Hawkins
2014/03/27 18:46:43
nit: Indentation should be 4 spaces in only.
James Hawkins
2014/03/27 18:46:43
nit: Remove stub content, i.e., NAME.
Shrikant Kelkar
2014/03/27 19:28:07
Done.
Shrikant Kelkar
2014/03/27 19:28:07
Done.
| |
| 55 </span> | 55 <span> |
| 56 </div> | 56 - <span i18n-content="componentVersion">VERSION</span> |
| 57 <div class="component-actions" guest-visibility="disabled"> | 57 <span dir="ltr" jscontent="version">x.x.x.x</span> |
| 58 <button class="button-check-update" jsvalues=".id:id" | 58 </span> |
| 59 i18n-content="checkUpdate"> | 59 </div> |
| 60 CHECK_UPDATE | 60 </div> |
| 61 </button> | 61 </td> |
| 62 </div> | 62 </tr> |
| 63 </div> | 63 <tr> |
| 64 <td> | |
| 65 <div class="component-text"> | |
| 66 <span>Status</span> | |
| 67 - | |
| 68 <span class="component-name" dir="ltr" | |
| 69 jscontent="status" jsvalues=".id: 'status-' + id">Okay </span> | |
|
James Hawkins
2014/03/27 18:46:43
nit: 80 cols.
Shrikant Kelkar
2014/03/27 19:28:07
Done.
| |
| 70 <span> | |
| 71 </div> | |
| 72 </td> | |
| 73 </tr> | |
| 74 <tr> | |
| 75 <td> | |
| 76 <div class="component-actions" guest-visibility="disabled"> | |
| 77 <button class="button-check-update" | |
| 78 jsvalues=".id:id" | |
| 79 i18n-content="checkUpdate"> | |
| 80 CHECK_UPDATE | |
| 81 </button> | |
| 82 </div> | |
| 83 </td> | |
| 84 </tr> | |
| 85 </table> | |
| 64 </td> | 86 </td> |
| 65 </tr> | 87 </tr> |
| 66 </table> | 88 </table> |
| 67 </div> | 89 </div> |
| 68 </div> | 90 </div> |
| 69 </div> | 91 </div> |
| 70 </div> | 92 </div> |
| 71 </div> | 93 </div> |
| 72 <script src="chrome://resources/js/util.js"></script> | 94 <script src="chrome://resources/js/util.js"></script> |
| 73 <script src="chrome://resources/js/cr.js"></script> | 95 <script src="chrome://resources/js/cr.js"></script> |
| 74 <script src="chrome://components/components.js"></script> | 96 <script src="chrome://components/components.js"></script> |
| 75 <if expr="chromeos"> | 97 <if expr="chromeos"> |
| 76 <script src="chrome://resources/js/chromeos/ui_account_tweaks.js"></script> | 98 <script src="chrome://resources/js/chromeos/ui_account_tweaks.js"></script> |
| 77 </if> | 99 </if> |
| 78 | 100 |
| 79 <script src="chrome://resources/js/load_time_data.js"></script> | 101 <script src="chrome://resources/js/load_time_data.js"></script> |
| 80 <script src="chrome://resources/js/jstemplate_compiled.js"></script> | 102 <script src="chrome://resources/js/jstemplate_compiled.js"></script> |
| 81 <script src="chrome://components/strings.js"></script> | 103 <script src="chrome://components/strings.js"></script> |
| 82 <script src="chrome://resources/js/i18n_template2.js"></script> | 104 <script src="chrome://resources/js/i18n_template2.js"></script> |
| 83 </body> | 105 </body> |
| 84 </html> | 106 </html> |
| OLD | NEW |
