Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/browser/resources/components.js

Issue 209313002: Modified components ui to address concern of all the time disabled check update button. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 'use strict'; 5 'use strict';
6 6
7 /** 7 /**
8 * Takes the |componentsData| input argument which represents data about the 8 * Takes the |componentsData| input argument which represents data about the
9 * currently installed components and populates the html jstemplate with 9 * currently installed components and populates the html jstemplate with
10 * that data. It expects an object structure like the above. 10 * that data. It expects an object structure like the above.
11 * @param {Object} componentsData Detailed info about installed components. 11 * @param {Object} componentsData Detailed info about installed components.
12 * Same expected format as returnComponentsData(). 12 * Same expected format as returnComponentsData().
13 */ 13 */
14 function renderTemplate(componentsData) { 14 function renderTemplate(componentsData) {
15 // This is the javascript code that processes the template: 15 // This is the javascript code that processes the template:
16 var input = new JsEvalContext(componentsData); 16 var input = new JsEvalContext(componentsData);
17 var output = $('componentTemplate'); 17 var output = $('component-template').cloneNode(true);
18 $('component-placeholder').innerHTML = '';
19 $('component-placeholder').appendChild(output);
18 jstProcess(input, output); 20 jstProcess(input, output);
21 output.removeAttribute('hidden');
19 } 22 }
20 23
21 /** 24 /**
22 * Asks the C++ ComponentsDOMHandler to get details about the installed 25 * Asks the C++ ComponentsDOMHandler to get details about the installed
23 * components. 26 * components.
24 * The ComponentsDOMHandler should reply to returnComponentsData() (below). 27 * The ComponentsDOMHandler should reply to returnComponentsData() (below).
25 */ 28 */
26 function requestComponentsData() { 29 function requestComponentsData() {
27 chrome.send('requestComponentsData'); 30 chrome.send('requestComponentsData');
28 } 31 }
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 69
67 // Disable some controls for Guest in ChromeOS. 70 // Disable some controls for Guest in ChromeOS.
68 if (cr.isChromeOS) 71 if (cr.isChromeOS)
69 uiAccountTweaks.UIAccountTweaks.applyGuestModeVisibility(document); 72 uiAccountTweaks.UIAccountTweaks.applyGuestModeVisibility(document);
70 73
71 bodyContainer.style.visibility = 'visible'; 74 bodyContainer.style.visibility = 'visible';
72 body.className = 'show-tmi-mode-initial'; 75 body.className = 'show-tmi-mode-initial';
73 } 76 }
74 77
75 /** 78 /**
79 * This event function is called from component ui indicating changed state
James Hawkins 2014/05/28 23:01:11 Optional nit: s/ui/UI/
Shrikant Kelkar 2014/05/28 23:14:45 Done.
80 * of component updater service.
81 * @param {Object} eventArgs Contains event and component id. Component id is
James Hawkins 2014/05/28 23:01:11 Optiona nit: s/id/ID/
Shrikant Kelkar 2014/05/28 23:14:45 Done.
82 * optional.
83 */
84 function onComponentEvent(eventArgs) {
85 if (eventArgs['id']) {
86 var id = eventArgs['id'];
87 $('status-' + id).textContent = eventArgs['event'];
88 }
89 }
90
91 /**
76 * Handles an 'enable' or 'disable' button getting clicked. 92 * Handles an 'enable' or 'disable' button getting clicked.
77 * @param {HTMLElement} node The HTML element representing the component 93 * @param {HTMLElement} node The HTML element representing the component
78 * being checked for update. 94 * being checked for update.
79 */ 95 */
80 function handleCheckUpdate(node) { 96 function handleCheckUpdate(node) {
81 node.disabled = true; 97 $('status-' + String(node.id)).textContent =
98 loadTimeData.getString('checkingLabel');
99
82 // Tell the C++ ComponentssDOMHandler to check for update. 100 // Tell the C++ ComponentssDOMHandler to check for update.
83 chrome.send('checkUpdate', [String(node.id)]); 101 chrome.send('checkUpdate', [String(node.id)]);
84 } 102 }
85 103
86 // Get data and have it displayed upon loading. 104 // Get data and have it displayed upon loading.
87 document.addEventListener('DOMContentLoaded', requestComponentsData); 105 document.addEventListener('DOMContentLoaded', requestComponentsData);
88
89 // Add handlers to static HTML elements.
90 $('button-check-update').onclick = handleCheckUpdate;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698