Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/components.html

Issue 209313002: Modified components ui to address concern of all the time disabled check update button. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« chrome/browser/resources/components.css ('K') | « chrome/browser/resources/components.css ('k') | chrome/browser/resources/components.js » ('j') | chrome/browser/resources/components.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE HTML> 1 <!DOCTYPE HTML>
2 <html i18n-values="dir:textdirection;"> 2 <html i18n-values="dir:textdirection;">
3 <head> 3 <head>
4 <meta charset="utf-8"> 4 <meta charset="utf-8">
5 <title i18n-content="componentsTitle"></title> 5 <title i18n-content="componentsTitle"></title>
6 <link rel="stylesheet" href="components.css"> 6 <link rel="stylesheet" href="components.css">
7 <if expr="chromeos"> 7 <if expr="chromeos">
8 <link rel="stylesheet" 8 <link rel="stylesheet"
9 href="chrome://resources/css/chromeos/ui_account_tweaks.css"> 9 href="chrome://resources/css/chromeos/ui_account_tweaks.css">
10 </if> 10 </if>
11 </head> 11 </head>
12 <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize"> 12 <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize">
13 <div id="body-container" style="visibility:hidden"> 13 <div id="body-container" style="visibility:hidden">
14 14
15 <div id="header"><h1 i18n-content="componentsTitle">TITLE</h1></div> 15 <div id="header"><h1 i18n-content="componentsTitle">TITLE</h1></div>
16 16 <div id="component-placeholder"></div>
17 <div id="componentTemplate"> 17 <div id="component-template" hidden>
18 18
19 <div id="container" class="vbox-container"> 19 <div id="container" class="vbox-container">
20 <div id="top" class="wbox"> 20 <div id="top" class="wbox">
21 21
22 <div class="section-header"> 22 <div class="section-header">
23 <table><tr> 23 <span class="section-header-title" i18n-content="componentsTitle"
24 <td> 24 >TITLE</span>
James Hawkins 2014/05/28 23:01:11 nit: Remove placeholder text.
Shrikant Kelkar 2014/05/28 23:14:45 Done.
25 <span class="section-header-title" i18n-content="componentsTitle" 25 <span class="section-header-title"
26 >TITLE</span> 26 jsdisplay="components.length > 0">(<span
27 <span class="section-header-title" 27 jscontent="components.length"></span>)</span>
28 jsdisplay="components.length > 0">(<span
29 jscontent="components.length"></span>)</span>
30 </td>
31 </tr></table>
32 </div> 28 </div>
33 29
34 </div> 30 </div>
35 </div> 31 </div>
36 32
37 <div class="content"> 33 <div class="content">
38 <div class="component-name no-components" jsdisplay="components.length === 0"> 34 <div class="component-name no-components"
35 jsdisplay="components.length === 0">
39 <div i18n-content="noComponents">NO_COMPONENTS_ARE_INSTALLED</div> 36 <div i18n-content="noComponents">NO_COMPONENTS_ARE_INSTALLED</div>
40 </div> 37 </div>
41 38
42 <div jsdisplay="components.length > 0"> 39 <div jsdisplay="components.length > 0">
43 <div class="component" 40 <div class="component"
44 jsselect="components"> 41 jsselect="components">
45 <table> 42 <div class='component-enabled'>
46 <tr class='component-enabled'>
47 <td>
48 <div class="component-text"> 43 <div class="component-text">
49 <div> 44 <div>
50 <span class="component-name" dir="ltr" 45 <span class="component-name" dir="ltr"
51 jscontent="name">NAME</span> 46 jscontent="name">
47 </span>
52 <span> 48 <span>
53 - <span i18n-content="componentVersion">VERSION</span> 49 - <span i18n-content="componentVersion"></span>
54 <span dir="ltr" jscontent="version">x.x.x.x</span> 50 <span dir="ltr" jscontent="version"></span>
55 </span> 51 </span>
56 </div> 52 </div>
57 <div class="component-actions" guest-visibility="disabled">
58 <button class="button-check-update" jsvalues=".id:id"
59 i18n-content="checkUpdate">
60 CHECK_UPDATE
61 </button>
62 </div>
63 </div> 53 </div>
64 </td> 54 </div>
65 </tr> 55 <div class="component-text">
66 </table> 56 <span i18n-content="statusLabel"></span>
57 -
58 <span dir="ltr"
James Hawkins 2014/05/28 23:01:11 How does this work in RTL?
Shrikant Kelkar 2014/05/28 23:14:45 Not sure about RTL case. Will investigate and fix
James Hawkins 2014/05/28 23:17:45 RTL is first class. So we need to make sure it wo
59 jscontent="status" jsvalues=".id: 'status-' + id">
60 <span>
61 </div>
62 <div class="component-actions" guest-visibility="disabled">
63 <button class="button-check-update"
64 jsvalues=".id:id" i18n-content="checkUpdate">
65 </button>
66 </div>
67 </div> 67 </div>
68 </div> 68 </div>
69 </div> 69 </div>
70 </div> 70 </div>
71 </div> 71 </div>
72 <script src="chrome://resources/js/util.js"></script> 72 <script src="chrome://resources/js/util.js"></script>
73 <script src="chrome://resources/js/cr.js"></script> 73 <script src="chrome://resources/js/cr.js"></script>
74 <script src="chrome://components/components.js"></script> 74 <script src="chrome://components/components.js"></script>
75 <if expr="chromeos"> 75 <if expr="chromeos">
76 <script src="chrome://resources/js/chromeos/ui_account_tweaks.js"></script> 76 <script src="chrome://resources/js/chromeos/ui_account_tweaks.js"></script>
77 </if> 77 </if>
78 78
79 <script src="chrome://resources/js/load_time_data.js"></script> 79 <script src="chrome://resources/js/load_time_data.js"></script>
80 <script src="chrome://resources/js/jstemplate_compiled.js"></script> 80 <script src="chrome://resources/js/jstemplate_compiled.js"></script>
81 <script src="chrome://components/strings.js"></script> 81 <script src="chrome://components/strings.js"></script>
82 <script src="chrome://resources/js/i18n_template2.js"></script> 82 <script src="chrome://resources/js/i18n_template2.js"></script>
83 </body> 83 </body>
84 </html> 84 </html>
OLDNEW
« chrome/browser/resources/components.css ('K') | « chrome/browser/resources/components.css ('k') | chrome/browser/resources/components.js » ('j') | chrome/browser/resources/components.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698