Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/components.html

Issue 209313002: Modified components ui to address concern of all the time disabled check update button. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/component_updater/component_updater_service.cc ('k') | chrome/browser/resources/components.js » ('j') | chrome/browser/resources/components.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE HTML> 1 <!DOCTYPE HTML>
2 <html i18n-values="dir:textdirection;"> 2 <html i18n-values="dir:textdirection;">
3 <head> 3 <head>
4 <meta charset="utf-8"> 4 <meta charset="utf-8">
5 <title i18n-content="componentsTitle"></title> 5 <title i18n-content="componentsTitle"></title>
6 <link rel="stylesheet" href="components.css"> 6 <link rel="stylesheet" href="components.css">
7 <if expr="chromeos"> 7 <if expr="chromeos">
8 <link rel="stylesheet" 8 <link rel="stylesheet"
9 href="chrome://resources/css/chromeos/ui_account_tweaks.css"> 9 href="chrome://resources/css/chromeos/ui_account_tweaks.css">
10 </if> 10 </if>
11 </head> 11 </head>
12 <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize"> 12 <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize">
13 <div id="body-container" style="visibility:hidden"> 13 <div id="body-container" style="visibility:hidden">
14 14
15 <div id="header"><h1 i18n-content="componentsTitle">TITLE</h1></div> 15 <div id="header"><h1 i18n-content="componentsTitle">TITLE</h1></div>
16 16 <div id="component-placeholder"></div>
17 <div id="componentTemplate"> 17 <div id="component-template" hidden>
James Hawkins 2014/05/23 17:38:54 Please pull this out into a JS class. There are t
Shrikant Kelkar 2014/05/28 19:29:22 Wondering what are the pros/cons of moving this to
James Hawkins 2014/05/28 23:02:23 Since this is actually just structure (for the mos
18 18
19 <div id="container" class="vbox-container"> 19 <div id="container" class="vbox-container">
20 <div id="top" class="wbox"> 20 <div id="top" class="wbox">
21 21
22 <div class="section-header"> 22 <div class="section-header">
23 <table><tr> 23 <table><tr>
24 <td> 24 <td>
25 <span class="section-header-title" i18n-content="componentsTitle" 25 <span class="section-header-title" i18n-content="componentsTitle"
26 >TITLE</span> 26 >TITLE</span>
27 <span class="section-header-title" 27 <span class="section-header-title"
28 jsdisplay="components.length > 0">(<span 28 jsdisplay="components.length > 0">(<span
29 jscontent="components.length"></span>)</span> 29 jscontent="components.length"></span>)</span>
30 </td> 30 </td>
31 </tr></table> 31 </tr></table>
32 </div> 32 </div>
33 33
34 </div> 34 </div>
35 </div> 35 </div>
36 36
37 <div class="content"> 37 <div class="content">
38 <div class="component-name no-components" jsdisplay="components.length === 0"> 38 <div class="component-name no-components"
39 jsdisplay="components.length === 0">
39 <div i18n-content="noComponents">NO_COMPONENTS_ARE_INSTALLED</div> 40 <div i18n-content="noComponents">NO_COMPONENTS_ARE_INSTALLED</div>
40 </div> 41 </div>
41 42
42 <div jsdisplay="components.length > 0"> 43 <div jsdisplay="components.length > 0">
43 <div class="component" 44 <div class="component"
44 jsselect="components"> 45 jsselect="components">
45 <table> 46 <table>
46 <tr class='component-enabled'> 47 <tr class='component-enabled'>
47 <td> 48 <td>
48 <div class="component-text"> 49 <table>
James Hawkins 2014/05/23 17:38:54 This isn't tabular data, so you should not being u
Shrikant Kelkar 2014/05/28 19:29:22 Done.
49 <div> 50 <tr>
50 <span class="component-name" dir="ltr" 51 <td>
51 jscontent="name">NAME</span> 52 <div class="component-text">
52 <span> 53 <div>
53 - <span i18n-content="componentVersion">VERSION</span> 54 <span class="component-name" dir="ltr"
54 <span dir="ltr" jscontent="version">x.x.x.x</span> 55 jscontent="name">
55 </span> 56 </span>
56 </div> 57 <span>
57 <div class="component-actions" guest-visibility="disabled"> 58 - <span i18n-content="componentVersion"></span>
58 <button class="button-check-update" jsvalues=".id:id" 59 <span dir="ltr" jscontent="version"></span>
59 i18n-content="checkUpdate"> 60 </span>
60 CHECK_UPDATE 61 </div>
61 </button> 62 </div>
62 </div> 63 </td>
63 </div> 64 </tr>
65 <tr>
66 <td>
67 <div class="component-text">
68 <span i18n-content="statusLabel"></span>
69 -
70 <span dir="ltr"
71 jscontent="status" jsvalues=".id: 'status-' + id">
James Hawkins 2014/05/23 17:38:54 It appears this value is not translated. It is co
Shrikant Kelkar 2014/05/28 19:29:22 Done.
72 <span>
73 </div>
74 </td>
75 </tr>
76 <tr>
77 <td>
78 <div class="component-actions" guest-visibility="disabled">
79 <button class="button-check-update"
80 jsvalues=".id:id" i18n-content="checkUpdate">
81 </button>
82 </div>
83 </td>
84 </tr>
85 </table>
64 </td> 86 </td>
65 </tr> 87 </tr>
66 </table> 88 </table>
67 </div> 89 </div>
68 </div> 90 </div>
69 </div> 91 </div>
70 </div> 92 </div>
71 </div> 93 </div>
72 <script src="chrome://resources/js/util.js"></script> 94 <script src="chrome://resources/js/util.js"></script>
73 <script src="chrome://resources/js/cr.js"></script> 95 <script src="chrome://resources/js/cr.js"></script>
74 <script src="chrome://components/components.js"></script> 96 <script src="chrome://components/components.js"></script>
75 <if expr="chromeos"> 97 <if expr="chromeos">
76 <script src="chrome://resources/js/chromeos/ui_account_tweaks.js"></script> 98 <script src="chrome://resources/js/chromeos/ui_account_tweaks.js"></script>
77 </if> 99 </if>
78 100
79 <script src="chrome://resources/js/load_time_data.js"></script> 101 <script src="chrome://resources/js/load_time_data.js"></script>
80 <script src="chrome://resources/js/jstemplate_compiled.js"></script> 102 <script src="chrome://resources/js/jstemplate_compiled.js"></script>
81 <script src="chrome://components/strings.js"></script> 103 <script src="chrome://components/strings.js"></script>
82 <script src="chrome://resources/js/i18n_template2.js"></script> 104 <script src="chrome://resources/js/i18n_template2.js"></script>
83 </body> 105 </body>
84 </html> 106 </html>
OLDNEW
« no previous file with comments | « chrome/browser/component_updater/component_updater_service.cc ('k') | chrome/browser/resources/components.js » ('j') | chrome/browser/resources/components.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698