Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Side by Side Diff: chrome/browser/ui/webui/components_ui.h

Issue 209313002: Modified components ui to address concern of all the time disabled check update button. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_COMPONENTS_UI_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_COMPONENTS_UI_H_
6 #define CHROME_BROWSER_UI_WEBUI_COMPONENTS_UI_H_ 6 #define CHROME_BROWSER_UI_WEBUI_COMPONENTS_UI_H_
7 7
8 #include "chrome/browser/component_updater/component_updater_service.h"
9 #include "chrome/browser/component_updater/crx_update_item.h"
8 #include "content/public/browser/web_ui_controller.h" 10 #include "content/public/browser/web_ui_controller.h"
9 #include "ui/base/layout.h" 11 #include "ui/base/layout.h"
10 12
11 namespace base { 13 namespace base {
12 class RefCountedMemory; 14 class RefCountedMemory;
13 } 15 }
14 16
15 namespace user_prefs { 17 namespace user_prefs {
16 class PrefRegistrySyncable; 18 class PrefRegistrySyncable;
17 } 19 }
18 20
19 class ComponentsUI : public content::WebUIController { 21 class ComponentsUI : public content::WebUIController,
22 public component_updater::ServiceObserver {
20 public: 23 public:
21 explicit ComponentsUI(content::WebUI* web_ui); 24 explicit ComponentsUI(content::WebUI* web_ui);
25 ~ComponentsUI();
22 26
23 static void OnDemandUpdate(const std::string& component_id); 27 static void OnDemandUpdate(const std::string& component_id);
24 28
29 static base::ListValue* LoadComponents();
30
25 static base::RefCountedMemory* GetFaviconResourceBytes( 31 static base::RefCountedMemory* GetFaviconResourceBytes(
26 ui::ScaleFactor scale_factor); 32 ui::ScaleFactor scale_factor);
27 33
34 // Override from ServiceObserver
35 virtual void OnEvent(Events event, const std::string& id) OVERRIDE;
36
28 private: 37 private:
38 static void ComponentEventToString(Events event,
Sorin Jianu 2014/05/16 16:36:09 We could return a std::string just like the simila
Shrikant Kelkar 2014/05/16 18:58:56 Done.
39 std::string* converted_event);
Sorin Jianu 2014/05/16 16:36:09 We need to rename |converted_event| here as well t
Shrikant Kelkar 2014/05/16 18:58:56 Modified to return string.
40 static std::string ServiceStatusToString(
41 component_updater::CrxUpdateItem::Status status);
29 DISALLOW_COPY_AND_ASSIGN(ComponentsUI); 42 DISALLOW_COPY_AND_ASSIGN(ComponentsUI);
30 }; 43 };
31 44
32 #endif // CHROME_BROWSER_UI_WEBUI_COMPONENTS_UI_H_ 45 #endif // CHROME_BROWSER_UI_WEBUI_COMPONENTS_UI_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698