Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.h

Issue 2093113003: Clean up the RWHVMac to ui::Compositor interface (phase 1 of 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove hack Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac.h
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.h b/content/browser/renderer_host/render_widget_host_view_mac.h
index 4076a3366ff66f348bc4d892e98f35071d92c4e2..3a64e1f4d4e1deb18bbad26213e60cc46a61f0e2 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.h
+++ b/content/browser/renderer_host/render_widget_host_view_mac.h
@@ -415,51 +415,9 @@ class CONTENT_EXPORT RenderWidgetHostViewMac
// The background CoreAnimation layer which is hosted by |cocoa_view_|.
base::scoped_nsobject<CALayer> background_layer_;
- // The state of |delegated_frame_host_| and |browser_compositor_| to
- // manage being visible, hidden, or occluded.
- enum BrowserCompositorViewState {
- // Effects:
- // - |browser_compositor_| exists and |delegated_frame_host_| is
- // visible.
- // Happens when:
- // - |render_widet_host_| is in the visible state (this includes when
- // the tab isn't visible, but tab capture is enabled).
- BrowserCompositorActive,
- // Effects:
- // - |browser_compositor_| exists, but |delegated_frame_host_| has
- // been hidden.
- // Happens when:
- // - The |render_widget_host_| is hidden, but |cocoa_view_| is still in the
- // NSWindow hierarchy.
- // - This happens when |cocoa_view_| is hidden (minimized, on another
- // occluded by other windows, etc). The |browser_compositor_| and
- // its CALayers are kept around so that we will have content to show when
- // we are un-occluded.
- BrowserCompositorSuspended,
- // Effects:
- // - |browser_compositor_| has been destroyed and
- // |delegated_frame_host_| has been hidden.
- // Happens when:
- // - The |render_widget_host_| is hidden or dead, and |cocoa_view_| is not
- // attached to a NSWindow.
- // - This happens for backgrounded tabs.
- BrowserCompositorDestroyed,
- };
- BrowserCompositorViewState browser_compositor_state_;
-
- // Delegated frame management and compositor.
- std::unique_ptr<DelegatedFrameHost> delegated_frame_host_;
- std::unique_ptr<ui::Layer> root_layer_;
-
- // Container for ui::Compositor the CALayer tree drawn by it.
+ // Delegated frame management and compositor interface.
std::unique_ptr<BrowserCompositorMac> browser_compositor_;
- // Placeholder that is allocated while browser_compositor_ is NULL,
- // indicating that a BrowserCompositorViewMac may be allocated. This is to
- // help in recycling the internals of BrowserCompositorViewMac.
- std::unique_ptr<BrowserCompositorMacPlaceholder>
- browser_compositor_placeholder_;
-
// Set when the currently-displayed frame is the minimum scale. Used to
// determine if pinch gestures need to be thresholded.
bool page_at_minimum_scale_;
@@ -521,10 +479,6 @@ class CONTENT_EXPORT RenderWidgetHostViewMac
base::TimeTicks* timebase, base::TimeDelta* interval) const override;
void AcceleratedWidgetSwapCompleted() override;
- // Transition from being in the Suspended state to being in the Destroyed
- // state, if appropriate (see BrowserCompositorViewState for details).
- void DestroySuspendedBrowserCompositorViewIfNeeded();
-
// Exposed for testing.
cc::SurfaceId SurfaceIdForTesting() const override;
@@ -538,16 +492,6 @@ class CONTENT_EXPORT RenderWidgetHostViewMac
// invoke it from the message loop.
void ShutdownHost();
- // Tear down all components of the browser compositor in an order that will
- // ensure no dangling references.
- void ShutdownBrowserCompositor();
-
- // The state of the the browser compositor and delegated frame host. See
- // BrowserCompositorViewState for details.
- void EnsureBrowserCompositorView();
- void SuspendBrowserCompositorView();
- void DestroyBrowserCompositorView();
-
// IPC message handlers.
void OnGetRenderedTextCompleted(const std::string& text);

Powered by Google App Engine
This is Rietveld 408576698