Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2093113002:
Reorder functions. (Closed)
|
Created:
4 years, 6 months ago by Pete Williamson Modified:
4 years, 6 months ago CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReorder RequestCoordinator functions.
To make it easier to understand the flow of a request through the
system, I re-ordered the functions to flow from top to bottom - in
most cases, the control of the async operation will call the next
function down in the file next.
No actual code changes were made, this changelist only moves existing
functions with no changes.
BUG=610521
Committed: https://crrev.com/ea61866e4aa197a1172e7460c27284e4237eb9ac
Cr-Commit-Position: refs/heads/master@{#401922}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 17 (7 generated)
petewil@chromium.org changed reviewers: + dougarnett@chromium.org, fgorski@chromium.org
The CQ bit was checked by petewil@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm - Please edit issue first with bit more meaningful first line - eg, "Reorder functions" => "Reorder RequestCoordinator functions"
Description was changed from ========== Reorder functions. To make it easier to understand the flow of a request through the system, I re-ordered the functions to flow from top to bottom - in most cases, the control of the async operation will call the next function down in the file next. No actual code changes were made, this changelist only moves existing functions with no changes. BUG=610521 ========== to ========== Reorder RequestCoordinator functions. To make it easier to understand the flow of a request through the system, I re-ordered the functions to flow from top to bottom - in most cases, the control of the async operation will call the next function down in the file next. No actual code changes were made, this changelist only moves existing functions with no changes. BUG=610521 ==========
On 2016/06/24 17:13:16, dougarnett wrote: > lgtm - Please edit issue first with bit more meaningful first line - eg, > "Reorder functions" => "Reorder RequestCoordinator functions" Changelist description first line edited as DougArnett suggests.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm with one request. https://codereview.chromium.org/2093113002/diff/1/components/offline_pages/ba... File components/offline_pages/background/request_coordinator.cc (right): https://codereview.chromium.org/2093113002/diff/1/components/offline_pages/ba... components/offline_pages/background/request_coordinator.cc:171: Scheduler::TriggerConditions const& Could you also update the order here to const type& and in the header. I think we both missed it in original review.
The CQ bit was checked by petewil@chromium.org
On 2016/06/24 18:39:17, fgorski wrote: > lgtm with one request. > > https://codereview.chromium.org/2093113002/diff/1/components/offline_pages/ba... > File components/offline_pages/background/request_coordinator.cc (right): > > https://codereview.chromium.org/2093113002/diff/1/components/offline_pages/ba... > components/offline_pages/background/request_coordinator.cc:171: > Scheduler::TriggerConditions const& > Could you also update the order here to const type& and in the header. I think > we both missed it in original review. I will do the request in a separate change.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Reorder RequestCoordinator functions. To make it easier to understand the flow of a request through the system, I re-ordered the functions to flow from top to bottom - in most cases, the control of the async operation will call the next function down in the file next. No actual code changes were made, this changelist only moves existing functions with no changes. BUG=610521 ========== to ========== Reorder RequestCoordinator functions. To make it easier to understand the flow of a request through the system, I re-ordered the functions to flow from top to bottom - in most cases, the control of the async operation will call the next function down in the file next. No actual code changes were made, this changelist only moves existing functions with no changes. BUG=610521 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Reorder RequestCoordinator functions. To make it easier to understand the flow of a request through the system, I re-ordered the functions to flow from top to bottom - in most cases, the control of the async operation will call the next function down in the file next. No actual code changes were made, this changelist only moves existing functions with no changes. BUG=610521 ========== to ========== Reorder RequestCoordinator functions. To make it easier to understand the flow of a request through the system, I re-ordered the functions to flow from top to bottom - in most cases, the control of the async operation will call the next function down in the file next. No actual code changes were made, this changelist only moves existing functions with no changes. BUG=610521 Committed: https://crrev.com/ea61866e4aa197a1172e7460c27284e4237eb9ac Cr-Commit-Position: refs/heads/master@{#401922} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ea61866e4aa197a1172e7460c27284e4237eb9ac Cr-Commit-Position: refs/heads/master@{#401922} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
