Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 209303002: Revert "[CSS Shapes] clamp RasterShape shapeMargin to reference box size" (Closed)

Created:
6 years, 9 months ago by eae
Modified:
6 years, 9 months ago
Reviewers:
pdr.
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Revert "[CSS Shapes] clamp RasterShape shapeMargin to reference box size" This reverts r258671 (commit 04d85dfa329176dc489bdcf9d2654f38e72a484e) as it broke android. BUG=355167 TBR=pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -65 lines) Patch
D LayoutTests/fast/shapes/shape-outside-floats/shape-outside-one-pixel.html View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/fast/shapes/shape-outside-floats/shape-outside-one-pixel-expected.html View 1 chunk +0 lines, -26 lines 0 comments Download
M Source/core/rendering/shapes/RasterShape.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/shapes/RasterShape.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/core/rendering/shapes/Shape.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-22 00:15:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/209303002/1
6 years, 9 months ago (2014-03-22 00:15:35 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-22 00:16:46 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-22 00:16:46 UTC) #4
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-22 00:17:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/209303002/1
6 years, 9 months ago (2014-03-22 00:17:15 UTC) #6
eae
6 years, 9 months ago (2014-03-22 00:25:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r169771 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698