Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1843)

Unified Diff: src/compiler/graph-visualizer.cc

Issue 2093013002: [turbolizer] Show a label with a shorter parameter for some opcodes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Merge with master Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/common-operator.cc ('k') | src/compiler/operator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/graph-visualizer.cc
diff --git a/src/compiler/graph-visualizer.cc b/src/compiler/graph-visualizer.cc
index 385fbc569c31a648cd5592156b09538e59068d11..7eb4c84211c0af828c130546844354dee6f1020d 100644
--- a/src/compiler/graph-visualizer.cc
+++ b/src/compiler/graph-visualizer.cc
@@ -124,10 +124,12 @@ class JSONGraphNodeWriter {
} else {
os_ << ",\n";
}
- std::ostringstream label;
- label << *node->op();
+ std::ostringstream label, title;
+ node->op()->PrintTo(label, Operator::PrintVerbosity::kSilent);
+ node->op()->PrintTo(title, Operator::PrintVerbosity::kVerbose);
os_ << "{\"id\":" << SafeId(node) << ",\"label\":\"" << Escaped(label, "\"")
- << "\"";
+ << "\""
+ << ",\"title\":\"" << Escaped(title, "\"") << "\"";
IrOpcode::Value opcode = node->opcode();
if (IrOpcode::IsPhiOpcode(opcode)) {
os_ << ",\"rankInputs\":[0," << NodeProperties::FirstControlIndex(node)
« no previous file with comments | « src/compiler/common-operator.cc ('k') | src/compiler/operator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698