chrome/browser/download/download_query.h - Issue 2092963002: downloads.query: parse numerical query properties as double, not int.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_query.h

Issue 2092963002: downloads.query: parse numerical query properties as double, not int. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add one more edge case test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/download/download_query.h

diff --git a/chrome/browser/download/download_query.h b/chrome/browser/download/download_query.h

index 980e53110b4879a67d3476be3aeea657b85f3ebf..b88f3bdebd9353b471ee7b880f4071d95bd4ce43 100644

--- a/chrome/browser/download/download_query.h

+++ b/chrome/browser/download/download_query.h

@@ -52,7 +52,7 @@ class DownloadQuery {

// All times are ISO 8601 strings.

enum FilterType {

- FILTER_BYTES_RECEIVED, // int

+ FILTER_BYTES_RECEIVED, // double

FILTER_DANGER_ACCEPTED, // bool

FILTER_ENDED_AFTER, // string

FILTER_ENDED_BEFORE, // string

@@ -66,9 +66,9 @@ class DownloadQuery {

FILTER_STARTED_AFTER, // string

FILTER_STARTED_BEFORE, // string

FILTER_START_TIME, // string

- FILTER_TOTAL_BYTES, // int

- FILTER_TOTAL_BYTES_GREATER, // int

- FILTER_TOTAL_BYTES_LESS, // int

+ FILTER_TOTAL_BYTES, // double

+ FILTER_TOTAL_BYTES_GREATER, // double

+ FILTER_TOTAL_BYTES_LESS, // double

FILTER_URL, // string

FILTER_URL_REGEX, // string

};

« no previous file with comments | « no previous file | chrome/browser/download/download_query.cc » ('j') | no next file with comments »