Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4091)

Unified Diff: chrome/browser/download/download_query.h

Issue 2092963002: downloads.query: parse numerical query properties as double, not int. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add one more edge case test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/download/download_query.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_query.h
diff --git a/chrome/browser/download/download_query.h b/chrome/browser/download/download_query.h
index 980e53110b4879a67d3476be3aeea657b85f3ebf..b88f3bdebd9353b471ee7b880f4071d95bd4ce43 100644
--- a/chrome/browser/download/download_query.h
+++ b/chrome/browser/download/download_query.h
@@ -52,7 +52,7 @@ class DownloadQuery {
// All times are ISO 8601 strings.
enum FilterType {
- FILTER_BYTES_RECEIVED, // int
+ FILTER_BYTES_RECEIVED, // double
FILTER_DANGER_ACCEPTED, // bool
FILTER_ENDED_AFTER, // string
FILTER_ENDED_BEFORE, // string
@@ -66,9 +66,9 @@ class DownloadQuery {
FILTER_STARTED_AFTER, // string
FILTER_STARTED_BEFORE, // string
FILTER_START_TIME, // string
- FILTER_TOTAL_BYTES, // int
- FILTER_TOTAL_BYTES_GREATER, // int
- FILTER_TOTAL_BYTES_LESS, // int
+ FILTER_TOTAL_BYTES, // double
+ FILTER_TOTAL_BYTES_GREATER, // double
+ FILTER_TOTAL_BYTES_LESS, // double
FILTER_URL, // string
FILTER_URL_REGEX, // string
};
« no previous file with comments | « no previous file | chrome/browser/download/download_query.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698