third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp - Issue 2092953002: Enable under-invalidation checking in tests calling runAfterLayoutAndPaint()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

Issue 2092953002: Enable under-invalidation checking in tests calling runAfterLayoutAndPaint() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mark some test failure Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp b/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

index 7a3cfb4f7bf081b928af2c6143fac2c545b74fc5..2b7413f8c49a3ec6d590679d313807dd080d4337 100644

--- a/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

+++ b/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

@@ -598,8 +598,11 @@ void GraphicsLayer::trackPaintInvalidation(const DisplayItemClient& client, cons

return;

PaintInvalidationTracking& tracking = paintInvalidationTrackingMap().add(this, PaintInvalidationTracking()).storedValue->value;

- PaintInvalidationInfo info = { &client, client.debugName(), rect, reason };

- tracking.trackedPaintInvalidations.append(info);

+ if (m_isTrackingPaintInvalidations) {

chrishtr 2016/06/24 17:15:15 Why is this conditional newly needed? Was it an ov

+ PaintInvalidationInfo info = { &client, client.debugName(), rect, reason };

+ tracking.trackedPaintInvalidations.append(info);

+ }

#if DCHECK_IS_ON()

if (RuntimeEnabledFeatures::slimmingPaintUnderInvalidationCheckingEnabled()) {

« third_party/WebKit/LayoutTests/TestExpectations ('K') | « third_party/WebKit/LayoutTests/resources/run-after-layout-and-paint.js ('k') | no next file » | no next file with comments »