Enable under-invalidation checking in tests calling runAfterLayoutAndPaint()

Enable under-invalidation checking in tests calling runAfterLayoutAndPaint()

These tests often change dom/style after a complete paint and test how
the rendering pipeline handles the changes. They are good candidate
for under-invalidation checking.

BUG=619103
Committed: https://crrev.com/86f41e76c78effe2493b639354696530a5ee23f6
Cr-Commit-Position: refs/heads/master@{#403355}

[Xianzhu, 2016-06-24 00:24:05]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2016-06-24 17:15:15]

https://codereview.chromium.org/2092953002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2092953002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:1216: crbug.com/619103
paint/overflow/interest-rect-change-scroll-down.html [ Failure ]
Not a good idea to fix these before committing?

https://codereview.chromium.org/2092953002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp (right):

https://codereview.chromium.org/2092953002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp:602: if
(m_isTrackingPaintInvalidations) {
Why is this conditional newly needed? Was it an oversight?

[Xianzhu, 2016-06-24 18:00:38]

https://codereview.chromium.org/2092953002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2092953002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:1216: crbug.com/619103
paint/overflow/interest-rect-change-scroll-down.html [ Failure ]
On 2016/06/24 17:15:15, chrishtr wrote:
> Not a good idea to fix these before committing?

It may need some time to fix them, and I need the test coverage of dynamic
changes (though we will lose test coverage of these several tests) for new paint
invalidation changes. I added Hotlist-Fixit-PE2016 on crbug.com/619103 and will
work on it soon.

[chrishtr, 2016-06-30 20:10:27]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-06-30 20:10:28]

lgtm

[commit-bot: I haz the power, 2016-06-30 20:11:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 21:20:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 21:20:57]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2016-06-30 21:32:27]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-06-30 21:33:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 23:57:10]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-30 23:59:07]

Description was changed from

==========
Enable under-invalidation checking in tests calling runAfterLayoutAndPaint()

These tests often change dom/style after a complete paint and test how
the rendering pipeline handles the changes. They are good candidate
for under-invalidation checking.

BUG=619103
==========

to

==========
Enable under-invalidation checking in tests calling runAfterLayoutAndPaint()

These tests often change dom/style after a complete paint and test how
the rendering pipeline handles the changes. They are good candidate
for under-invalidation checking.

BUG=619103

Committed: https://crrev.com/86f41e76c78effe2493b639354696530a5ee23f6
Cr-Commit-Position: refs/heads/master@{#403355}
==========

[commit-bot: I haz the power, 2016-06-30 23:59:08]

Patchset 4 (id:??) landed as
https://crrev.com/86f41e76c78effe2493b639354696530a5ee23f6
Cr-Commit-Position: refs/heads/master@{#403355}