Issue 2092913004: Skip unresolved functions in NoSuchMethodRegistry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2092913004: Skip unresolved functions in NoSuchMethodRegistry (Closed)

Created:
4 years, 6 months ago by Johnni Winther

Modified:
4 years, 5 months ago

Reviewers:
Harry Terkelsen

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Skip unresolved functions in NoSuchMethodRegistry Deserialized function do not have a [ResolvedAst] if they are not live. The first stop towards the best solution is to skip unresolved (not live) method, next step is to avoid registration of these methods in the first place. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/74775a65b2cc32df184a4828e9efc274f6a42c1a

Patch Set 1 #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -2 lines)			Patch
	M	pkg/compiler/lib/src/js_backend/no_such_method_registry.dart	View		2 chunks	+18 lines, -2 lines	0 comments	Download
	M	tests/compiler/dart2js/serialization/test_data.dart	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Johnni Winther

4 years, 5 months ago (2016-06-27 07:50:47 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
74775a65b2cc32df184a4828e9efc274f6a42c1a (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages