Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 2092893002: arc: Create sync protos for Arc package. (Closed)

Created:
4 years, 6 months ago by lgcheng
Modified:
4 years, 5 months ago
CC:
chromium-reviews, albertb+watch_chromium.org, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Create sync protos for Arc package. BUG=28024050 TEST=Add ARC_PACKAGE to current sync unit_tests. Unit_tests passed. Committed: https://crrev.com/0d492c850185975020601cbf6803c4edd24efc92 Cr-Commit-Position: refs/heads/master@{#402293}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Nits addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -11 lines) Patch
M components/browser_sync/browser/profile_sync_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/model_association_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_driver/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_driver/pref_names.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_driver/sync_prefs.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/user_selectable_sync_type.h View 2 chunks +3 lines, -1 line 0 comments Download
M sync/internal_api/public/base/model_type.h View 1 2 chunks +3 lines, -1 line 0 comments Download
A sync/protocol/arc_package_specifics.proto View 1 chunk +28 lines, -0 lines 0 comments Download
M sync/protocol/nigori_specifics.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/proto_value_conversions.h View 2 chunks +5 lines, -0 lines 0 comments Download
M sync/protocol/proto_value_conversions.cc View 4 chunks +14 lines, -0 lines 0 comments Download
M sync/protocol/proto_value_conversions_unittest.cc View 3 chunks +6 lines, -1 line 0 comments Download
M sync/protocol/protocol.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M sync/protocol/sync.proto View 2 chunks +2 lines, -0 lines 0 comments Download
M sync/syncable/model_type.cc View 1 4 chunks +9 lines, -1 line 0 comments Download
M sync/syncable/model_type_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M sync/syncable/nigori_util.cc View 4 chunks +5 lines, -2 lines 0 comments Download
M sync/tools/testserver/chromiumsync.py View 5 chunks +6 lines, -1 line 0 comments Download
M sync/util/data_type_histogram.h View 4 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Nicolas Zea
+Pavel, could you review?
4 years, 6 months ago (2016-06-24 06:32:49 UTC) #4
Nicolas Zea
Actually +Pavel this time.
4 years, 6 months ago (2016-06-24 06:33:08 UTC) #6
chromium-reviews
I'm OOO today. I'll review on Monday. On Thu, Jun 23, 2016 at 11:33 PM, ...
4 years, 6 months ago (2016-06-24 18:10:58 UTC) #7
pavely
lgtm with couple of nits. https://codereview.chromium.org/2092893002/diff/1/sync/internal_api/public/base/model_type.h File sync/internal_api/public/base/model_type.h (right): https://codereview.chromium.org/2092893002/diff/1/sync/internal_api/public/base/model_type.h#newcode134 sync/internal_api/public/base/model_type.h:134: // Arc Package items ...
4 years, 5 months ago (2016-06-27 18:51:33 UTC) #8
lgcheng
Nits addressed. Thanks for review! https://codereview.chromium.org/2092893002/diff/1/sync/internal_api/public/base/model_type.h File sync/internal_api/public/base/model_type.h (right): https://codereview.chromium.org/2092893002/diff/1/sync/internal_api/public/base/model_type.h#newcode134 sync/internal_api/public/base/model_type.h:134: // Arc Package items ...
4 years, 5 months ago (2016-06-27 19:54:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2092893002/20001
4 years, 5 months ago (2016-06-27 19:56:40 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-27 21:37:19 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 21:40:42 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0d492c850185975020601cbf6803c4edd24efc92
Cr-Commit-Position: refs/heads/master@{#402293}

Powered by Google App Engine
This is Rietveld 408576698