Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2092863004: Docked windows resized on unlock with vertical shelf position (Closed)

Created:
4 years, 5 months ago by Qiang(Joe) Xu
Modified:
4 years, 5 months ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Docked windows resized on unlock with vertical shelf position It is because there is a new added shelf state: SHELF_ALIGNMENT_BOTTOM_LOCKED for locked state, and it can change the display work area some time from locked state to unlocked state. BUG=622431 TEST=manually test saw bug goes away. Committed: https://crrev.com/074006e2e9f8c05f624876b54abc07fbb4658215 Cr-Commit-Position: refs/heads/master@{#402120}

Patch Set 1 #

Patch Set 2 : change crbug number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ash/shelf/shelf_layout_manager.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2092863004/1
4 years, 5 months ago (2016-06-25 05:06:26 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-25 05:45:09 UTC) #6
Qiang(Joe) Xu
Hi Stefan, could you PTAL? thanks!
4 years, 5 months ago (2016-06-25 06:23:24 UTC) #7
Mr4D (OOO till 08-26)
lgtm
4 years, 5 months ago (2016-06-27 04:27:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2092863004/20001
4 years, 5 months ago (2016-06-27 05:10:19 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-27 05:55:04 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 05:56:51 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/074006e2e9f8c05f624876b54abc07fbb4658215
Cr-Commit-Position: refs/heads/master@{#402120}

Powered by Google App Engine
This is Rietveld 408576698